Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Issue 2797703004: Android: Upgrade to Android Studio 2.3 (Closed)

Created:
3 years, 8 months ago by Peter Wen
Modified:
3 years, 8 months ago
Reviewers:
estevenson
CC:
chromium-reviews, mikecase+watch_chromium.org, nyquist+watch_chromium.org, jbudorick+watch_chromium.org, wnwen+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Upgrade to Android Studio 2.3 Support Clank development with the next version of Android Studio. BUG=700438 Review-Url: https://codereview.chromium.org/2797703004 Cr-Commit-Position: refs/heads/master@{#462050} Committed: https://chromium.googlesource.com/chromium/src/+/fdea62ce258c0abf7327f1081af9d964818c440f

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -14 lines) Patch
M build/android/gradle/generate_gradle.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/gradle/root.jinja View 1 chunk +1 line, -1 line 0 comments Download
M docs/android_studio.md View 5 chunks +18 lines, -12 lines 2 comments Download

Messages

Total messages: 13 (8 generated)
Peter Wen
Will update go/clank after this is submitted.
3 years, 8 months ago (2017-04-04 20:50:33 UTC) #2
estevenson
lgtm https://codereview.chromium.org/2797703004/diff/1/docs/android_studio.md File docs/android_studio.md (right): https://codereview.chromium.org/2797703004/diff/1/docs/android_studio.md#newcode30 docs/android_studio.md:30: * Clean up in `//third_party/android_tools` with `git clean ...
3 years, 8 months ago (2017-04-04 23:29:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797703004/1
3 years, 8 months ago (2017-04-05 13:08:26 UTC) #9
Peter Wen
Thanks for the review! https://codereview.chromium.org/2797703004/diff/1/docs/android_studio.md File docs/android_studio.md (right): https://codereview.chromium.org/2797703004/diff/1/docs/android_studio.md#newcode30 docs/android_studio.md:30: * Clean up in `//third_party/android_tools` ...
3 years, 8 months ago (2017-04-05 13:09:37 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 13:13:49 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fdea62ce258c0abf7327f1081af9...

Powered by Google App Engine
This is Rietveld 408576698