Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(22)

Issue 2797633003: Reduce number of redundant map lookups in QuicStreamFactory::OnJobComplete (Closed)

Created:
7 months, 2 weeks ago by xunjieli
Modified:
7 months, 2 weeks ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce number of redundant map lookups in QuicStreamFactory::OnJobComplete This CL reduces the number of redundant map lookups in QuicStreamFactory::OnJobComplete. BUG=708260 Review-Url: https://codereview.chromium.org/2797633003 Cr-Commit-Position: refs/heads/master@{#462076} Committed: https://chromium.googlesource.com/chromium/src/+/aa4eb39704c572837d41258bdaf3a46a4c03ed27

Patch Set 1 : self #

Total comments: 2

Patch Set 2 : Address comment #

Messages

Total messages: 27 (20 generated)
xunjieli
One more :)
7 months, 2 weeks ago (2017-04-04 19:25:47 UTC) #11
Ryan Hamilton
lgtm also great! https://codereview.chromium.org/2797633003/diff/20001/net/quic/chromium/quic_stream_factory.cc File net/quic/chromium/quic_stream_factory.cc (right): https://codereview.chromium.org/2797633003/diff/20001/net/quic/chromium/quic_stream_factory.cc#newcode1170 net/quic/chromium/quic_stream_factory.cc:1170: // It's okay not to erase ...
7 months, 2 weeks ago (2017-04-04 20:03:24 UTC) #12
xunjieli
Thanks! https://codereview.chromium.org/2797633003/diff/20001/net/quic/chromium/quic_stream_factory.cc File net/quic/chromium/quic_stream_factory.cc (right): https://codereview.chromium.org/2797633003/diff/20001/net/quic/chromium/quic_stream_factory.cc#newcode1170 net/quic/chromium/quic_stream_factory.cc:1170: // It's okay not to erase |request| from ...
7 months, 2 weeks ago (2017-04-04 21:25:23 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797633003/40001
7 months, 2 weeks ago (2017-04-04 21:26:11 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/264697)
7 months, 2 weeks ago (2017-04-05 01:41:58 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797633003/40001
7 months, 2 weeks ago (2017-04-05 14:29:07 UTC) #24
commit-bot: I haz the power
7 months, 2 weeks ago (2017-04-05 15:28:01 UTC) #27
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/aa4eb39704c572837d41258bdaf3...

Powered by Google App Engine
This is Rietveld efc10ee0f