Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2797633003:
Reduce number of redundant map lookups in QuicStreamFactory::OnJobComplete (Closed)
|
Created:
3 years, 8 months ago by xunjieli Modified:
3 years, 8 months ago Reviewers:
Ryan Hamilton CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionReduce number of redundant map lookups in QuicStreamFactory::OnJobComplete
This CL reduces the number of redundant map lookups in
QuicStreamFactory::OnJobComplete.
BUG=708260
Review-Url: https://codereview.chromium.org/2797633003
Cr-Commit-Position: refs/heads/master@{#462076}
Committed: https://chromium.googlesource.com/chromium/src/+/aa4eb39704c572837d41258bdaf3a46a4c03ed27
Patch Set 1 : self #
Total comments: 2
Patch Set 2 : Address comment #Messages
Total messages: 27 (20 generated)
Description was changed from ========== Reduce number of redundant map lookups in QuicStreamFactory::OnJobComplete BUG=708260 ========== to ========== Reduce number of redundant map lookups in QuicStreamFactory::OnJobComplete BUG=708260 ==========
xunjieli@chromium.org changed reviewers: + rch@chromium.org
The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run
xunjieli@chromium.org changed reviewers: - rch@chromium.org
The CQ bit was unchecked by xunjieli@chromium.org
Patchset #1 (id:1) has been deleted
The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run
Description was changed from ========== Reduce number of redundant map lookups in QuicStreamFactory::OnJobComplete BUG=708260 ========== to ========== Reduce number of redundant map lookups in QuicStreamFactory::OnJobComplete This CL reduces the number of redundant map lookups in QuicStreamFactory::OnJobComplete. BUG=708260 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
xunjieli@chromium.org changed reviewers: + rch@chromium.org
One more :)
lgtm also great! https://codereview.chromium.org/2797633003/diff/20001/net/quic/chromium/quic_... File net/quic/chromium/quic_stream_factory.cc (right): https://codereview.chromium.org/2797633003/diff/20001/net/quic/chromium/quic_... net/quic/chromium/quic_stream_factory.cc:1170: // It's okay not to erase |request| from |requests_iter->second| because we nit: avoid first person in comments. How 'bout something like: // It's okay not to erase |request| from |requests_iter->second| because // the entire RequestSet will be erased from |job_request_map_|.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run
Thanks! https://codereview.chromium.org/2797633003/diff/20001/net/quic/chromium/quic_... File net/quic/chromium/quic_stream_factory.cc (right): https://codereview.chromium.org/2797633003/diff/20001/net/quic/chromium/quic_... net/quic/chromium/quic_stream_factory.cc:1170: // It's okay not to erase |request| from |requests_iter->second| because we On 2017/04/04 20:03:24, Ryan Hamilton wrote: > nit: avoid first person in comments. How 'bout something like: > > // It's okay not to erase |request| from |requests_iter->second| because > // the entire RequestSet will be erased from |job_request_map_|. Done.
The CQ bit was unchecked by xunjieli@chromium.org
The CQ bit was checked by xunjieli@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org Link to the patchset: https://codereview.chromium.org/2797633003/#ps40001 (title: "Address comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by xunjieli@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491402514415600,
"parent_rev": "91c934e6b8a2b157d49ae8c0f03743642c11ca9c", "commit_rev":
"aa4eb39704c572837d41258bdaf3a46a4c03ed27"}
Message was sent while issue was closed.
Description was changed from ========== Reduce number of redundant map lookups in QuicStreamFactory::OnJobComplete This CL reduces the number of redundant map lookups in QuicStreamFactory::OnJobComplete. BUG=708260 ========== to ========== Reduce number of redundant map lookups in QuicStreamFactory::OnJobComplete This CL reduces the number of redundant map lookups in QuicStreamFactory::OnJobComplete. BUG=708260 Review-Url: https://codereview.chromium.org/2797633003 Cr-Commit-Position: refs/heads/master@{#462076} Committed: https://chromium.googlesource.com/chromium/src/+/aa4eb39704c572837d41258bdaf3... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/aa4eb39704c572837d41258bdaf3... |
