[Payments] Move PaymentMethodData to components/payments/core

[Payments] Move PaymentMethodData to components/payments/core

BUG=708052
TEST=components_unittests

Review-Url: https://codereview.chromium.org/2797633002
Cr-Commit-Position: refs/heads/master@{#461802}
Committed: https://chromium.googlesource.com/chromium/src/+/0a0f508c228156c161f59858e65c6ee06c14d650

[Mathieu, 2017-04-04 03:15:58]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 03:16:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mathieu, 2017-04-04 03:18:29]

Description was changed from

==========
[Payments] Move PaymentMethodData to components/payments/core

BUG=
TEST=components_unittests
==========

to

==========
[Payments] Move PaymentMethodData to components/payments/core

BUG=708052
TEST=components_unittests
==========

[Mathieu, 2017-04-04 03:18:29]

mathp@chromium.org changed reviewers:
+ mahmadi@chromium.org

[Mathieu, 2017-04-04 03:21:08]

Moe, PTAL

https://codereview.chromium.org/2797633002/diff/20001/components/payments/cor...
File components/payments/core/payment_method_data.cc (right):

https://codereview.chromium.org/2797633002/diff/20001/components/payments/cor...
components/payments/core/payment_method_data.cc:76: break;  // TODO(mathp): or
return false? or continue?
Not sure how this should validate. If item at this location is not a string, we
should probably return false, right?

[commit-bot: I haz the power, 2017-04-04 03:37:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 03:37:59]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Mathieu, 2017-04-04 12:33:03]

https://codereview.chromium.org/2797633002/diff/20001/components/payments/cor...
File components/payments/core/payment_method_data.cc (right):

https://codereview.chromium.org/2797633002/diff/20001/components/payments/cor...
components/payments/core/payment_method_data.cc:76: break;  // TODO(mathp): or
return false? or continue?
On 2017/04/04 03:21:08, Mathieu wrote:
> Not sure how this should validate. If item at this location is not a string,
we
> should probably return false, right?

I went with return false, as the caller should not use the result of this if
it's invalid.

[Moe, 2017-04-04 17:52:33]

On 2017/04/04 12:33:03, Mathieu wrote:
>
https://codereview.chromium.org/2797633002/diff/20001/components/payments/cor...
> File components/payments/core/payment_method_data.cc (right):
> 
>
https://codereview.chromium.org/2797633002/diff/20001/components/payments/cor...
> components/payments/core/payment_method_data.cc:76: break;  // TODO(mathp): or
> return false? or continue?
> On 2017/04/04 03:21:08, Mathieu wrote:
> > Not sure how this should validate. If item at this location is not a string,
> we
> > should probably return false, right?
> 
> I went with return false, as the caller should not use the result of this if
> it's invalid.

LGTM.

[Moe, 2017-04-04 17:52:50]

https://codereview.chromium.org/2797633002/diff/20001/components/payments/cor...
File components/payments/core/payment_method_data.cc (right):

https://codereview.chromium.org/2797633002/diff/20001/components/payments/cor...
components/payments/core/payment_method_data.cc:76: break;  // TODO(mathp): or
return false? or continue?
On 2017/04/04 12:33:02, Mathieu wrote:
> On 2017/04/04 03:21:08, Mathieu wrote:
> > Not sure how this should validate. If item at this location is not a string,
> we
> > should probably return false, right?
> 
> I went with return false, as the caller should not use the result of this if
> it's invalid.

I agree. Returning false makes more sense.

[Mathieu, 2017-04-04 18:02:03]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2017-04-04 18:03:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 19:28:02]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491328923313490,
"parent_rev": "0c80ac5421d4b7f81595b525163d54b686ca8785", "commit_rev":
"0a0f508c228156c161f59858e65c6ee06c14d650"}

[commit-bot: I haz the power, 2017-04-04 19:28:47]

Description was changed from

==========
[Payments] Move PaymentMethodData to components/payments/core

BUG=708052
TEST=components_unittests
==========

to

==========
[Payments] Move PaymentMethodData to components/payments/core

BUG=708052
TEST=components_unittests

Review-Url: https://codereview.chromium.org/2797633002
Cr-Commit-Position: refs/heads/master@{#461802}
Committed:
https://chromium.googlesource.com/chromium/src/+/0a0f508c228156c161f59858e65c...
==========

[commit-bot: I haz the power, 2017-04-04 19:28:49]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0a0f508c228156c161f59858e65c...