Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2797613002: Reland: Bluetooth: Add service data unit tests for chromeos (Closed)

Created:
3 years, 8 months ago by xiaoyinh(OOO Sep 11-29)
Modified:
3 years, 8 months ago
Reviewers:
Miao, rkc, ortuno
CC:
chromium-reviews, mac-reviews_chromium.org, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Bluetooth: Add service data unit tests for chromeos This CL verifies that: 1. service data is populated correctly during device creation. 2. service data is updated correctly on property changed. BUG=688566 Review-Url: https://codereview.chromium.org/2797613002 Cr-Commit-Position: refs/heads/master@{#461751} Committed: https://chromium.googlesource.com/chromium/src/+/d296cacc709ef513b7b1dde1a1ce272f7ff261d0

Patch Set 1 : original CL #

Patch Set 2 : fix the test data. #

Patch Set 3 : fix data #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -112 lines) Patch
M device/bluetooth/bluetooth_device_unittest.cc View 1 2 6 chunks +62 lines, -29 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_bluez_unittest.cc View 1 chunk +0 lines, -63 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_device_client.h View 2 chunks +17 lines, -6 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_device_client.cc View 3 chunks +30 lines, -1 line 0 comments Download
M device/bluetooth/test/bluetooth_test.h View 2 chunks +10 lines, -2 lines 0 comments Download
M device/bluetooth/test/bluetooth_test_bluez.cc View 2 chunks +18 lines, -9 lines 0 comments Download
M device/bluetooth/test/bluetooth_test_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
xiaoyinh(OOO Sep 11-29)
Hi, Could you help to take another look? I'm trying to reland the CL of ...
3 years, 8 months ago (2017-04-04 01:02:34 UTC) #2
ortuno
lgtm
3 years, 8 months ago (2017-04-04 01:11:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797613002/40001
3 years, 8 months ago (2017-04-04 16:33:46 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 16:53:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d296cacc709ef513b7b1dde1a1ce...

Powered by Google App Engine
This is Rietveld 408576698