Added some more roles to the list of roles that calculate their names from content.

Added some more roles to the list of roles that calculate their names from content.

This is in order to conform more closely to the ARIA standard and in order to fix a bug that prevented Jaws from reading the contents of ARIA grid cells in Forms Mode.
BUG=707810
R=dmazzoni@chromium.org, aboxhall@chromium.org, aleventhal@chromium.org
TESTED=manually with Jaws using snippet in the bug, browser tests

Review-Url: https://codereview.chromium.org/2797463002
Cr-Commit-Position: refs/heads/master@{#462663}
Committed: https://chromium.googlesource.com/chromium/src/+/07fa440786a29497120ec0c71e50cb8dc332b6eb

[nektarios, 2017-04-03 16:30:48]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 16:31:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 16:55:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 16:55:06]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[dmazzoni, 2017-04-03 17:10:40]

https://codereview.chromium.org/2797463002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/accessibility/AXObject.cpp (right):

https://codereview.chromium.org/2797463002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/accessibility/AXObject.cpp:1740: case RowRole:
Row may be problematic. Wouldn't that give the accessible name of the row the
text of all of its cells appended together?

Same with "tree". It seems like it would get all of the
items appended as its name.

The others seem fine.

[blink-reviews, 2017-04-03 18:43:26]

RowRole:
> Row may be problematic. Wouldn't that give the accessible name of the
> row the text of all of its cells appended together?
>
> Same with "tree". It seems like it would get all of the
> items appended as its name.

Yes, I know, this is what happens, all the children are appended to the 
row and tree as the name.
But, isn't this what the ARIA Spec wants us to do?

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2017-04-03 18:43:27]

RowRole:
> Row may be problematic. Wouldn't that give the accessible name of the
> row the text of all of its cells appended together?
>
> Same with "tree". It seems like it would get all of the
> items appended as its name.

Yes, I know, this is what happens, all the children are appended to the 
row and tree as the name.
But, isn't this what the ARIA Spec wants us to do?

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2017-04-03 19:55:54]

We shouldn't implement what the spec says if it's wrong and just breaks
existing apps. I think this will require more testing.


On Mon, Apr 3, 2017 at 11:43 AM 'Nektarios Paisios' via Chromium-reviews <
chromium-reviews@chromium.org> wrote:

> RowRole:
>
> Row may be problematic. Wouldn't that give the accessible name of the
> row the text of all of its cells appended together?
>
> Same with "tree". It seems like it would get all of the
> items appended as its name.
>
>
> Yes, I know, this is what happens, all the children are appended to the
> row and tree as the name.
> But, isn't this what the ARIA Spec wants us to do?
>
> --
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[dmazzoni, 2017-04-03 19:55:54]

We shouldn't implement what the spec says if it's wrong and just breaks
existing apps. I think this will require more testing.


On Mon, Apr 3, 2017 at 11:43 AM 'Nektarios Paisios' via Chromium-reviews <
chromium-reviews@chromium.org> wrote:

> RowRole:
>
> Row may be problematic. Wouldn't that give the accessible name of the
> row the text of all of its cells appended together?
>
> Same with "tree". It seems like it would get all of the
> items appended as its name.
>
>
> Yes, I know, this is what happens, all the children are appended to the
> row and tree as the name.
> But, isn't this what the ARIA Spec wants us to do?
>
> --
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[blink-reviews, 2017-04-03 21:45:10]

tree and row roles removed.

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2017-04-03 21:45:10]

tree and row roles removed.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[nektarios, 2017-04-03 21:45:36]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 21:46:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 22:17:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 22:17:16]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[dmazzoni, 2017-04-04 15:07:28]

Thanks. Tentatively sounds find but I'd like to see
what this does to the tests that are failing, thanks.

[dmazzoni, 2017-04-04 15:07:42]

Sorry, typo - tentatively sounds fine

[nektarios, 2017-04-04 20:51:47]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 20:52:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 21:41:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 21:41:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nektarios, 2017-04-06 17:01:40]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[nektarios, 2017-04-06 17:02:03]

Fixed test expectations.

[commit-bot: I haz the power, 2017-04-06 17:02:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nektarios, 2017-04-06 17:03:02]

Description was changed from

==========
Added some more roles to the list of roles that calculate their names from
content.

This is in order to conform more closely to the ARIA standard and in order to
fix a bug that prevented Jaws from reading the contents of ARIA grid cells in
Forms Mode.
BUG=707810
R=dmazzoni@chromium.org, aboxhall@chromium.org
TESTED=manually with Jaws using snippet in the bug, browser tests
==========

to

==========
Added some more roles to the list of roles that calculate their names from
content.

This is in order to conform more closely to the ARIA standard and in order to
fix a bug that prevented Jaws from reading the contents of ARIA grid cells in
Forms Mode.
BUG=707810
R=dmazzoni@chromium.org, aboxhall@chromium.org, aleventhal@chromium.org
TESTED=manually with Jaws using snippet in the bug, browser tests
==========

[nektarios, 2017-04-06 17:03:02]

nektar@chromium.org changed reviewers:
+ aleventhal@chromium.org

[nektarios, 2017-04-06 17:03:48]

@aleventhal
Let's get this checked in as a first step and then let's try to harmonize our
implementation with Firefox's.

[commit-bot: I haz the power, 2017-04-06 18:56:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 18:56:14]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2017-04-06 21:08:21]

lgtm

[nektarios, 2017-04-06 21:09:05]

The CQ bit was checked by nektar@chromium.org

[commit-bot: I haz the power, 2017-04-06 21:10:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 22:49:21]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491512945645320,
"parent_rev": "170f1cf7d23ce3e3fb99085042bf68b8772825a1", "commit_rev":
"07fa440786a29497120ec0c71e50cb8dc332b6eb"}

[commit-bot: I haz the power, 2017-04-06 22:50:13]

Description was changed from

==========
Added some more roles to the list of roles that calculate their names from
content.

This is in order to conform more closely to the ARIA standard and in order to
fix a bug that prevented Jaws from reading the contents of ARIA grid cells in
Forms Mode.
BUG=707810
R=dmazzoni@chromium.org, aboxhall@chromium.org, aleventhal@chromium.org
TESTED=manually with Jaws using snippet in the bug, browser tests
==========

to

==========
Added some more roles to the list of roles that calculate their names from
content.

This is in order to conform more closely to the ARIA standard and in order to
fix a bug that prevented Jaws from reading the contents of ARIA grid cells in
Forms Mode.
BUG=707810
R=dmazzoni@chromium.org, aboxhall@chromium.org, aleventhal@chromium.org
TESTED=manually with Jaws using snippet in the bug, browser tests

Review-Url: https://codereview.chromium.org/2797463002
Cr-Commit-Position: refs/heads/master@{#462663}
Committed:
https://chromium.googlesource.com/chromium/src/+/07fa440786a29497120ec0c71e50...
==========

[commit-bot: I haz the power, 2017-04-06 22:50:15]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/07fa440786a29497120ec0c71e50...