Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Issue 2797443004: Prevent autocomplete tests from being broken by data URL deprecation. (Closed)

Created:
3 years, 8 months ago by meacer
Modified:
3 years, 8 months ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent autocomplete tests from being broken by data URL deprecation. Content-initiated main-frame navigations to data URLs are being blocked in crbug.com/594215. The tests fixed here were form-posting to themselves which are data URLs and are going to be broken. Change form targets to about:blank URLs instead. BUG=594215 Review-Url: https://codereview.chromium.org/2797443004 Cr-Commit-Position: refs/heads/master@{#461786} Committed: https://chromium.googlesource.com/chromium/src/+/f44eeb03c89211aa7018c8cc536f9cab3bbe3def

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M chrome/browser/autofill/autofill_server_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/autofill/form_autocomplete_browsertest.cc View 4 chunks +18 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
meacer
estade: PTAL? Thanks.
3 years, 8 months ago (2017-04-03 23:28:33 UTC) #2
Evan Stade
I am not active on autofill, over to mathp
3 years, 8 months ago (2017-04-04 03:33:21 UTC) #4
vabr (Chromium)
LGTM, thanks for the fix! Vaclav
3 years, 8 months ago (2017-04-04 09:15:55 UTC) #6
meacer
Thanks!
3 years, 8 months ago (2017-04-04 17:29:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797443004/1
3 years, 8 months ago (2017-04-04 17:30:15 UTC) #9
Mathieu
lgtm
3 years, 8 months ago (2017-04-04 17:43:25 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 18:45:40 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f44eeb03c89211aa7018c8cc536f...

Powered by Google App Engine
This is Rietveld 408576698