Fix screen mirroring on Chrome OS (ReflectorTexture partial swap)

Fix screen mirroring on Chrome OS (ReflectorTexture partial swap)

Copying texture subimage requires the texture to already be
defined, so ensure ReflectorTexture performs a full copy before any
partial copies.

Bug was caused by https://codereview.chromium.org/2699173002/, since
partial swap with subrect == surface size was previously implicitly
treated as a full swap.

BUG=702713
Review-Url: https://codereview.chromium.org/2797443003
Cr-Commit-Position: refs/heads/master@{#461568}
Committed: https://chromium.googlesource.com/chromium/src/+/08ae4cdea9398a15871e80126e6f2fbd47a4fa9b

[halliwell, 2017-04-03 19:27:48]

Description was changed from

==========
Fix screen mirroring on Chrome OS (ReflectorTexture partial swap)

Copying texture subimage requires the texture to already be
defined, so ensure ReflectorTexture performs a full copy before any
partial copies.

Bug was caused by https://codereview.chromium.org/2699173002/, since
partial swap with subrect == surface size was previously implicitly
treated as a full swap.

BUG=702713
==========

to

==========
Fix screen mirroring on Chrome OS (ReflectorTexture partial swap)

Copying texture subimage requires the texture to already be
defined, so ensure ReflectorTexture performs a full copy before any
partial copies.

Bug was caused by https://codereview.chromium.org/2699173002/, since
partial swap with subrect == surface size was previously implicitly
treated as a full swap.

BUG=702713
==========

[halliwell, 2017-04-03 19:27:48]

halliwell@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2017-04-03 19:30:56]

https://codereview.chromium.org/2797443003/diff/1/content/browser/compositor/...
File content/browser/compositor/gpu_browser_compositor_output_surface.cc
(right):

https://codereview.chromium.org/2797443003/diff/1/content/browser/compositor/...
content/browser/compositor/gpu_browser_compositor_output_surface.cc:111: if
(frame.sub_buffer_rect && reflector_texture_->is_texture_defined()) {
Looks like this bool could live on this class here instead?

[halliwell, 2017-04-03 20:31:36]

On 2017/04/03 19:30:56, danakj wrote:
>
https://codereview.chromium.org/2797443003/diff/1/content/browser/compositor/...
> File content/browser/compositor/gpu_browser_compositor_output_surface.cc
> (right):
> 
>
https://codereview.chromium.org/2797443003/diff/1/content/browser/compositor/...
> content/browser/compositor/gpu_browser_compositor_output_surface.cc:111: if
> (frame.sub_buffer_rect && reflector_texture_->is_texture_defined()) {
> Looks like this bool could live on this class here instead?

Sure, done.

[danakj, 2017-04-03 21:33:45]

LGTM I like this, makes it very clear we take the second branch the first time
always.

[danakj, 2017-04-03 21:33:51]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2017-04-03 21:34:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 22:56:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491255231573980,
"parent_rev": "c15a4e2b594e61442419a6fec5c5e15ba303dc01", "commit_rev":
"08ae4cdea9398a15871e80126e6f2fbd47a4fa9b"}

[commit-bot: I haz the power, 2017-04-03 22:57:34]

Description was changed from

==========
Fix screen mirroring on Chrome OS (ReflectorTexture partial swap)

Copying texture subimage requires the texture to already be
defined, so ensure ReflectorTexture performs a full copy before any
partial copies.

Bug was caused by https://codereview.chromium.org/2699173002/, since
partial swap with subrect == surface size was previously implicitly
treated as a full swap.

BUG=702713
==========

to

==========
Fix screen mirroring on Chrome OS (ReflectorTexture partial swap)

Copying texture subimage requires the texture to already be
defined, so ensure ReflectorTexture performs a full copy before any
partial copies.

Bug was caused by https://codereview.chromium.org/2699173002/, since
partial swap with subrect == surface size was previously implicitly
treated as a full swap.

BUG=702713

Review-Url: https://codereview.chromium.org/2797443003
Cr-Commit-Position: refs/heads/master@{#461568}
Committed:
https://chromium.googlesource.com/chromium/src/+/08ae4cdea9398a15871e80126e6f...
==========

[commit-bot: I haz the power, 2017-04-03 22:57:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/08ae4cdea9398a15871e80126e6f...