Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Issue 2797443002: Check callback is run in QuicChromiumClientSession's destructor (Closed)

Created:
3 years, 8 months ago by xunjieli
Modified:
3 years, 8 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Check callback is run in QuicChromiumClientSession's destructor Add a DCHECK to make sure |callback_| has been run in QuicChromiumClientSession's destructor. BUG=704949 Review-Url: https://codereview.chromium.org/2797443002 Cr-Commit-Position: refs/heads/master@{#461558} Committed: https://chromium.googlesource.com/chromium/src/+/e23ca12cab688382ed5a3e3350885bed0b9d39b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M net/quic/chromium/quic_chromium_client_session.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
xunjieli
3 years, 8 months ago (2017-04-03 15:10:51 UTC) #4
Zhongyi Shi
lgtm
3 years, 8 months ago (2017-04-03 22:15:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797443002/1
3 years, 8 months ago (2017-04-03 22:16:45 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 22:24:35 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e23ca12cab688382ed5a3e335088...

Powered by Google App Engine
This is Rietveld 408576698