Remove ResourceFetcher::preloads

Remove ResourceFetcher::preloads

This CL removes ResourceFetcher::preloads as a preliminary change for changing
how preloaded resources are held in ResourceFetcher.

BUG=652228
Review-Url: https://codereview.chromium.org/2797423003
Cr-Commit-Position: refs/heads/master@{#462812}
Committed: https://chromium.googlesource.com/chromium/src/+/b63a4f94ae3e6b72ed0107f5525cc48615a0e118

[yhirano, 2017-04-06 12:44:07]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 12:44:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-04-06 12:48:10]

yhirano@chromium.org changed reviewers:
+ yoav@yoav.ws, yutak@chromium.org

[yhirano, 2017-04-06 12:48:11]

+yoav@ for the overall change.
+yutak@ for std::vector usage in LinkLoaderTest.cpp. Is it allowed?

[commit-bot: I haz the power, 2017-04-06 12:58:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 12:58:29]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Yuta Kitamura, 2017-04-07 04:36:10]

https://codereview.chromium.org/2797423003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp (right):

https://codereview.chromium.org/2797423003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp:146: // We cannot use
WTF::Vector because wtf has not been initialized yet.
I'd suggest making those parameters a constexpr array and putting it
as a namespace-level or function-level static value. This should work,
because those constants are all primitive values.

E.g.

constexpr PreloadTestParams kLinkLoaderPreloadParams[] = {
  {"http://...", ..., },
  {...},
  ...
};

INSTANTIATE_TEST_CASE_P(...,
  ::testing::ValuesIn(kLinkLoaderPreloadParams));

The last expression should work because ValuesIn can directly take
an array:
https://cs.chromium.org/chromium/src/testing/gtest/include/gtest/gtest-param-...

[yhirano, 2017-04-07 05:55:46]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 05:56:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yoav Weiss, 2017-04-07 07:00:34]

On 2017/04/07 04:36:10, Yuta Kitamura wrote:
>
https://codereview.chromium.org/2797423003/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp (right):
> 
>
https://codereview.chromium.org/2797423003/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp:146: // We cannot use
> WTF::Vector because wtf has not been initialized yet.
> I'd suggest making those parameters a constexpr array and putting it
> as a namespace-level or function-level static value. This should work,
> because those constants are all primitive values.
> 
> E.g.
> 
> constexpr PreloadTestParams kLinkLoaderPreloadParams[] = {
>   {"http://...", ..., },
>   {...},
>   ...
> };
> 
> INSTANTIATE_TEST_CASE_P(...,
>   ::testing::ValuesIn(kLinkLoaderPreloadParams));
> 
> The last expression should work because ValuesIn can directly take
> an array:
>
https://cs.chromium.org/chromium/src/testing/gtest/include/gtest/gtest-param-...

LGTM

[yhirano, 2017-04-07 07:22:38]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 07:22:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-04-07 07:49:02]

https://codereview.chromium.org/2797423003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp (right):

https://codereview.chromium.org/2797423003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp:146: // We cannot use
WTF::Vector because wtf has not been initialized yet.
On 2017/04/07 04:36:10, Yuta Kitamura wrote:
> I'd suggest making those parameters a constexpr array and putting it
> as a namespace-level or function-level static value. This should work,
> because those constants are all primitive values.
> 
> E.g.
> 
> constexpr PreloadTestParams kLinkLoaderPreloadParams[] = {
>   {"http://...", ..., },
>   {...},
>   ...
> };
> 
> INSTANTIATE_TEST_CASE_P(...,
>   ::testing::ValuesIn(kLinkLoaderPreloadParams));
> 
> The last expression should work because ValuesIn can directly take
> an array:
>
https://cs.chromium.org/chromium/src/testing/gtest/include/gtest/gtest-param-...

Thanks, done.

[Yuta Kitamura, 2017-04-07 07:54:46]

Tests LGTM

[yhirano, 2017-04-07 07:55:15]

The CQ bit was unchecked by yhirano@chromium.org

[yhirano, 2017-04-07 07:55:15]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2017-04-07 07:55:16]

The patchset sent to the CQ was uploaded after l-g-t-m from yoav@yoav.ws
Link to the patchset: https://codereview.chromium.org/2797423003/#ps40001
(title: "fix")

[commit-bot: I haz the power, 2017-04-07 07:55:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 08:48:28]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491551715950970,
"parent_rev": "3602528ca6d0a7b9bf3b8569c1974ced69249eb7", "commit_rev":
"b63a4f94ae3e6b72ed0107f5525cc48615a0e118"}

[commit-bot: I haz the power, 2017-04-07 08:49:15]

Description was changed from

==========
Remove ResourceFetcher::preloads

This CL removes ResourceFetcher::preloads as a preliminary change for changing
how preloaded resources are held in ResourceFetcher.

BUG=652228
==========

to

==========
Remove ResourceFetcher::preloads

This CL removes ResourceFetcher::preloads as a preliminary change for changing
how preloaded resources are held in ResourceFetcher.

BUG=652228

Review-Url: https://codereview.chromium.org/2797423003
Cr-Commit-Position: refs/heads/master@{#462812}
Committed:
https://chromium.googlesource.com/chromium/src/+/b63a4f94ae3e6b72ed0107f5525c...
==========

[commit-bot: I haz the power, 2017-04-07 08:49:16]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b63a4f94ae3e6b72ed0107f5525c...