Merge features of cronet_licenses.py into licenses.py.

Merge features of cronet_licenses.py into licenses.py.

Motivation here is to generate LICENSE file for //ios/web_view in the
same way as //components/cronet/tools/cronet_licenses.py. To avoid code
duplication, I merged features of cronet_licenses.py into licenses.py
and will use it for //ios/web_view.

I can remove cronet_licenses.py and use licenses.py instead to generate
Cronet license file too in a separated CL if it sounds good.

Merged features:
- Generate a plain text LICENSE file for a given GN target.
- Make the script work inside GN action rules.

Review-Url: https://codereview.chromium.org/2797403002
Cr-Commit-Position: refs/heads/master@{#463537}
Committed: https://chromium.googlesource.com/chromium/src/+/cc4ae12d1dffdfef4d816b945ac200b853e622b6

[Hiroshi Ichikawa, 2017-04-06 04:50:45]

Description was changed from

==========
Merge features of cronet_licenses.py into licenses.py.

BUG=
==========

to

==========
Merge features of cronet_licenses.py into licenses.py.

Motivation here is to generate LICENSE file for //ios/web_view in the same way
as //components/cronet/tools/cronet_licenses.py. To avoid code duplication, I
merged features of cronet_licenses.py into licenses.py and will use it for
//ios/web_view.

I can remove cronet_licenses.py and use licenses.py instead to generate Cronet
license file too in a separated CL if it sounds good.

Merged features:
- Generate a plain text LICENSE file for a given GN target.
- Make the script work inside GN action rules.
==========

[Hiroshi Ichikawa, 2017-04-06 04:53:25]

ichikawa@chromium.org changed reviewers:
+ mef@chromium.org, phajdan.jr@chromium.org

[Hiroshi Ichikawa, 2017-04-06 04:53:25]

mef@: Did you have any reason to separate cronet_licenses.py from licenses.py?

[Hiroshi Ichikawa, 2017-04-06 08:18:29]

Description was changed from

==========
Merge features of cronet_licenses.py into licenses.py.

Motivation here is to generate LICENSE file for //ios/web_view in the same way
as //components/cronet/tools/cronet_licenses.py. To avoid code duplication, I
merged features of cronet_licenses.py into licenses.py and will use it for
//ios/web_view.

I can remove cronet_licenses.py and use licenses.py instead to generate Cronet
license file too in a separated CL if it sounds good.

Merged features:
- Generate a plain text LICENSE file for a given GN target.
- Make the script work inside GN action rules.
==========

to

==========
Merge features of cronet_licenses.py into licenses.py.

Motivation here is to generate LICENSE file for //ios/web_view in the
same way as //components/cronet/tools/cronet_licenses.py. To avoid code
duplication, I merged features of cronet_licenses.py into licenses.py
and will use it for //ios/web_view.

I can remove cronet_licenses.py and use licenses.py instead to generate
Cronet license file too in a separated CL if it sounds good.

Merged features:
- Generate a plain text LICENSE file for a given GN target.
- Make the script work inside GN action rules.
==========

[Paweł Hajdan Jr., 2017-04-06 11:52:13]

LGTM w/nits

https://codereview.chromium.org/2797403002/diff/1/tools/licenses.py
File tools/licenses.py (right):

https://codereview.chromium.org/2797403002/diff/1/tools/licenses.py#newcode494
tools/licenses.py:494: shutil.copy(gn_out_dir + "/args.gn", tmp_dir)
nit: Use os.path.join instead of "+".

https://codereview.chromium.org/2797403002/diff/1/tools/licenses.py#newcode654
tools/licenses.py:654: content.append(directory.split("/")[-1])
nit: Use single quotes ' .

[Hiroshi Ichikawa, 2017-04-07 01:47:16]

https://codereview.chromium.org/2797403002/diff/1/tools/licenses.py
File tools/licenses.py (right):

https://codereview.chromium.org/2797403002/diff/1/tools/licenses.py#newcode494
tools/licenses.py:494: shutil.copy(gn_out_dir + "/args.gn", tmp_dir)
On 2017/04/06 11:52:13, Paweł Hajdan Jr. wrote:
> nit: Use os.path.join instead of "+".

Done.

https://codereview.chromium.org/2797403002/diff/1/tools/licenses.py#newcode654
tools/licenses.py:654: content.append(directory.split("/")[-1])
On 2017/04/06 11:52:13, Paweł Hajdan Jr. wrote:
> nit: Use single quotes ' .

Done.

[mef, 2017-04-10 15:48:12]

lgtm. 

There was no particular reason to have separate cronet_licenses.py apart from
the concern of messing up the Chrome proper.

I'm especially happy to see _GnBinary() as we were unable to use gn on Cronet
Android bots without it.

[Hiroshi Ichikawa, 2017-04-11 03:42:40]

On 2017/04/10 15:48:12, mef wrote:
> lgtm. 
> 
> There was no particular reason to have separate cronet_licenses.py apart from
> the concern of messing up the Chrome proper.

I see, thanks. What do you think if we replace use of cronet_licenses.py with
licenses.py and remove cronet_licenses.py? I can do that (when I have time) if
you are OK with that. One feature still missing in licenses.py is an option to
use hard-coded dependencies instead of calling gn:
https://cs.chromium.org/chromium/src/components/cronet/tools/cronet_licenses....
But would that be still needed?

[Hiroshi Ichikawa, 2017-04-11 03:42:47]

The CQ bit was checked by ichikawa@chromium.org

[Hiroshi Ichikawa, 2017-04-11 03:42:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/2797403002/#ps20001
(title: "Apply review comments.")

[commit-bot: I haz the power, 2017-04-11 03:43:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 05:03:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491882167061650,
"parent_rev": "011ef8d97d0b06877ca4cfc621d2e56f19aeef8c", "commit_rev":
"cc4ae12d1dffdfef4d816b945ac200b853e622b6"}

[commit-bot: I haz the power, 2017-04-11 05:05:32]

Description was changed from

==========
Merge features of cronet_licenses.py into licenses.py.

Motivation here is to generate LICENSE file for //ios/web_view in the
same way as //components/cronet/tools/cronet_licenses.py. To avoid code
duplication, I merged features of cronet_licenses.py into licenses.py
and will use it for //ios/web_view.

I can remove cronet_licenses.py and use licenses.py instead to generate
Cronet license file too in a separated CL if it sounds good.

Merged features:
- Generate a plain text LICENSE file for a given GN target.
- Make the script work inside GN action rules.
==========

to

==========
Merge features of cronet_licenses.py into licenses.py.

Motivation here is to generate LICENSE file for //ios/web_view in the
same way as //components/cronet/tools/cronet_licenses.py. To avoid code
duplication, I merged features of cronet_licenses.py into licenses.py
and will use it for //ios/web_view.

I can remove cronet_licenses.py and use licenses.py instead to generate
Cronet license file too in a separated CL if it sounds good.

Merged features:
- Generate a plain text LICENSE file for a given GN target.
- Make the script work inside GN action rules.

Review-Url: https://codereview.chromium.org/2797403002
Cr-Commit-Position: refs/heads/master@{#463537}
Committed:
https://chromium.googlesource.com/chromium/src/+/cc4ae12d1dffdfef4d816b945ac2...
==========

[commit-bot: I haz the power, 2017-04-11 05:05:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cc4ae12d1dffdfef4d816b945ac2...

[mef, 2017-04-11 14:58:55]

On 2017/04/11 03:42:40, Hiroshi Ichikawa wrote:
> On 2017/04/10 15:48:12, mef wrote:
> > lgtm. 
> > 
> > There was no particular reason to have separate cronet_licenses.py apart
from
> > the concern of messing up the Chrome proper.
> 
> I see, thanks. What do you think if we replace use of cronet_licenses.py with
> licenses.py and remove cronet_licenses.py? I can do that (when I have time) if
> you are OK with that. 
I'll be totally happy and grateful if you do that. :)
Please note that cronet_licenses.py is used for both iOS and Android builds.

>One feature still missing in licenses.py is an option to
> use hard-coded dependencies instead of calling gn:
>
https://cs.chromium.org/chromium/src/components/cronet/tools/cronet_licenses....
> But would that be still needed?

The hardcoded list was used before gn. 
It is still used on Android because https://codereview.chromium.org/2150933007/
has failed to find gn on the buildbot.
I hope that _GnBinary() fixes that and we wouldn't need hardcoded list.

[Hiroshi Ichikawa, 2017-04-12 09:33:38]

On 2017/04/11 14:58:55, mef wrote:
> On 2017/04/11 03:42:40, Hiroshi Ichikawa wrote:
> > On 2017/04/10 15:48:12, mef wrote:
> > > lgtm. 
> > > 
> > > There was no particular reason to have separate cronet_licenses.py apart
> from
> > > the concern of messing up the Chrome proper.
> > 
> > I see, thanks. What do you think if we replace use of cronet_licenses.py
with
> > licenses.py and remove cronet_licenses.py? I can do that (when I have time)
if
> > you are OK with that. 
> I'll be totally happy and grateful if you do that. :)
> Please note that cronet_licenses.py is used for both iOS and Android builds.

Thanks, filed a bug crbug.com/710801

> 
> >One feature still missing in licenses.py is an option to
> > use hard-coded dependencies instead of calling gn:
> >
>
https://cs.chromium.org/chromium/src/components/cronet/tools/cronet_licenses....
> > But would that be still needed?
> 
> The hardcoded list was used before gn. 
> It is still used on Android because
https://codereview.chromium.org/2150933007/
> has failed to find gn on the buildbot.
> I hope that _GnBinary() fixes that and we wouldn't need hardcoded list.