Introduce RenderFrameVisitor

Introduce RenderFrameVisitor

This patch introduces RenderFrameVisitor, so that we can perform batch
operations to each living RenderFrame.

This patch is a preparation for making SpellCheckProvider a
RenderFrameObserver: https://crrev.com/2799923003

BUG=638361
Review-Url: https://codereview.chromium.org/2797383002
Cr-Commit-Position: refs/heads/master@{#463827}
Committed: https://chromium.googlesource.com/chromium/src/+/57078b411bb68d6db438b05bd90e2bd60cb670e4

[Xiaocheng, 2017-04-05 23:24:29]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 23:25:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 01:14:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 01:14:26]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-04-10 19:14:54]

Description was changed from

==========
Introduce RenderFrameVisitor

BUG=
==========

to

==========
Introduce RenderFrameVisitor

This patch introduces RenderFrameVisitor, so that we can perform batch
operations to each living RenderFrame.

This patch is a preparation for making SpellCheckProvider a
RenderFrameObserver: https://crrev.com/2799923003

BUG=638361
==========

[Xiaocheng, 2017-04-10 19:15:42]

xiaochengh@chromium.org changed reviewers:
+ nick@chromium.org

[Xiaocheng, 2017-04-10 19:15:43]

PTAL.

[Xiaocheng, 2017-04-10 21:07:32]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 21:08:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 22:59:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 22:59:24]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-04-11 20:12:30]

xiaochengh@chromium.org changed reviewers:
+ creis@chromium.org

[Xiaocheng, 2017-04-11 20:12:31]

+creis & friendly ping...

[Charlie Reis, 2017-04-11 21:26:33]

Thanks-- LGTM if you intend it for iterating over all local frames in the whole
process, and not just in a given page.

https://codereview.chromium.org/2797383002/diff/1/content/public/renderer/ren...
File content/public/renderer/render_frame_visitor.h (right):

https://codereview.chromium.org/2797383002/diff/1/content/public/renderer/ren...
content/public/renderer/render_frame_visitor.h:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
nit: 2017, no (c)

[Xiaocheng, 2017-04-11 21:42:15]

Thanks for the review!

Yes, it's intended for the entire process.

https://codereview.chromium.org/2797383002/diff/1/content/public/renderer/ren...
File content/public/renderer/render_frame_visitor.h (right):

https://codereview.chromium.org/2797383002/diff/1/content/public/renderer/ren...
content/public/renderer/render_frame_visitor.h:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
On 2017/04/11 at 21:26:33, Charlie Reis wrote:
> nit: 2017, no (c)

Just copied everything from render_view_visitor.h and forgot to modify copyright
note...

[Xiaocheng, 2017-04-11 22:07:33]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2017-04-11 22:07:34]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org
Link to the patchset: https://codereview.chromium.org/2797383002/#ps20001
(title: "Use the correct copyright notice")

[commit-bot: I haz the power, 2017-04-11 22:08:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 23:16:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491948453915280,
"parent_rev": "f62584dc6a463324c181a09725dae46a824022f4", "commit_rev":
"57078b411bb68d6db438b05bd90e2bd60cb670e4"}

[commit-bot: I haz the power, 2017-04-11 23:17:28]

Description was changed from

==========
Introduce RenderFrameVisitor

This patch introduces RenderFrameVisitor, so that we can perform batch
operations to each living RenderFrame.

This patch is a preparation for making SpellCheckProvider a
RenderFrameObserver: https://crrev.com/2799923003

BUG=638361
==========

to

==========
Introduce RenderFrameVisitor

This patch introduces RenderFrameVisitor, so that we can perform batch
operations to each living RenderFrame.

This patch is a preparation for making SpellCheckProvider a
RenderFrameObserver: https://crrev.com/2799923003

BUG=638361

Review-Url: https://codereview.chromium.org/2797383002
Cr-Commit-Position: refs/heads/master@{#463827}
Committed:
https://chromium.googlesource.com/chromium/src/+/57078b411bb68d6db438b05bd90e...
==========

[commit-bot: I haz the power, 2017-04-11 23:17:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/57078b411bb68d6db438b05bd90e...