Fixing std::swap(x, x) in base.

base/process/process_posix.cc

Index: base/process/process_posix.cc
diff --git a/base/process/process_posix.cc b/base/process/process_posix.cc
index 9b94891dd961ba8b972ead181bf4ca5d1c0beca4..bbb342c4cf49a4b6c9072faacf5e6df78f384140 100644
--- a/base/process/process_posix.cc
+++ b/base/process/process_posix.cc
@@ -225,7 +225,6 @@ Process::Process(Process&& other) : process_(other.process_) {
 }
 
 Process& Process::operator=(Process&& other) {
-  DCHECK_NE(this, &other);
   process_ = other.process_;
   other.Close();

[danakj, 2017/04/05 19:17:40]

How does this not close itself?

[danakj, 2017/04/05 20:33:41]

This looks like a broken assignment period.

Process a, b;
a = std::move(b);

would copy b's process_ to a and then close it, closing itself?

[dyaroshev, 2017/04/05 20:42:47]

Closing actually just assigns a special value to handle. In case of self move
assignment it is just closing itself. This seems to be ok.

[danakj, 2017/04/05 20:59:34]

Hrm.. ok ya.. weird. That wasn't what I expected, I read windows code where
process_ was a scoped thing, my mistake.

   return *this;