Fixing std::swap(x, x) in base.

base/process/process_posix.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/process/process.h"
 
 #include <errno.h>
 #include <stdint.h>
 #include <sys/resource.h>
 #include <sys/wait.h>
@@ skipping 207 matching lines @@
 }
 
 Process::~Process() {
 }
 
 Process::Process(Process&& other) : process_(other.process_) {
   other.Close();
 }
 
 Process& Process::operator=(Process&& other) {
-  DCHECK_NE(this, &other);
   process_ = other.process_;
   other.Close();

[danakj, 2017/04/05 19:17:40]

How does this not close itself?

[danakj, 2017/04/05 20:33:41]

This looks like a broken assignment period.

Process a, b;
a = std::move(b);

would copy b's process_ to a and then close it, closing itself?

[dyaroshev, 2017/04/05 20:42:47]

Closing actually just assigns a special value to handle. In case of self move
assignment it is just closing itself. This seems to be ok.

[danakj, 2017/04/05 20:59:34]

Hrm.. ok ya.. weird. That wasn't what I expected, I read windows code where
process_ was a scoped thing, my mistake.

   return *this;
 }
 
 // static
 Process Process::Current() {
   return Process(GetCurrentProcessHandle());
 }
 
 // static
 Process Process::Open(ProcessId pid) {
@@ skipping 140 matching lines @@
   return false;
 }
 #endif  // !defined(OS_LINUX) && !defined(OS_MACOSX)
 
 int Process::GetPriority() const {
   DCHECK(IsValid());
   return getpriority(PRIO_PROCESS, process_);
 }
 
 }  // namespace base