Aura-Mus: Implement gutter in the embedder.

Aura-Mus: Implement gutter in the embedder.

This CL implements gutter in the embedder.

In a nutshell, when a Fallback SurfaceInfo is set, the embedder computes 
the right and bottom gutter layers if necessary.

It takes the difference between the window size and the fallback surface 
size, and computes the position and size of the gutters.

The gutter layers are recomputed on window bounds change.

Window types EMBED_IN_OWNER and TOP_LEVEL_IN_WM always get a 
ClientSurfaceEmbedder now.

Note that currently, if surface synchronization is turned on then the 
frame rate will always be 15fps because SurfaceLayers may refer (and 
block) on hidden windows that don't produce CompositorFrames. This will
be fixed in a subsequent CL.

BUG=672962
Review-Url: https://codereview.chromium.org/2797263002
Cr-Commit-Position: refs/heads/master@{#463041}
Committed: https://chromium.googlesource.com/chromium/src/+/0cbd038c0fb0221a18b27ef3cf52362f5b2d1877

[Fady Samuel, 2017-04-05 23:33:53]

Description was changed from

==========
WIP: Aura-Mus: Implement gutter in the embedder.

BUG=
==========

to

==========
Aura-Mus: Implement gutter in the embedder.

This CL implements gutter in the embedder.

In a nutshell, when a Fallback SurfaceInfo is set, the embedder computes ight
and bottom gutter layers if necessary.

It takes the difference between the window size and the fallback surface 
size, and computes the position and size of the gutters.

BUG=
==========

[Fady Samuel, 2017-04-05 23:34:50]

Description was changed from

==========
Aura-Mus: Implement gutter in the embedder.

This CL implements gutter in the embedder.

In a nutshell, when a Fallback SurfaceInfo is set, the embedder computes ight
and bottom gutter layers if necessary.

It takes the difference between the window size and the fallback surface 
size, and computes the position and size of the gutters.

BUG=
==========

to

==========
Aura-Mus: Implement gutter in the embedder.

This CL implements gutter in the embedder.

In a nutshell, when a Fallback SurfaceInfo is set, the embedder computes the
right and bottom gutter layers if necessary.

It takes the difference between the window size and the fallback surface 
size, and computes the position and size of the gutters.

The gutter layers are recomputed on window bounds change.

Window types EMBED_IN_OWNER and TOP_LEVEL_IN_WM always get a 
ClientSurfaceEmbedder now.

BUG=
==========

[Fady Samuel, 2017-04-05 23:34:57]

Description was changed from

==========
Aura-Mus: Implement gutter in the embedder.

This CL implements gutter in the embedder.

In a nutshell, when a Fallback SurfaceInfo is set, the embedder computes the
right and bottom gutter layers if necessary.

It takes the difference between the window size and the fallback surface 
size, and computes the position and size of the gutters.

The gutter layers are recomputed on window bounds change.

Window types EMBED_IN_OWNER and TOP_LEVEL_IN_WM always get a 
ClientSurfaceEmbedder now.

BUG=
==========

to

==========
Aura-Mus: Implement gutter in the embedder.

This CL implements gutter in the embedder.

In a nutshell, when a Fallback SurfaceInfo is set, the embedder computes 
the right and bottom gutter layers if necessary.

It takes the difference between the window size and the fallback surface 
size, and computes the position and size of the gutters.

The gutter layers are recomputed on window bounds change.

Window types EMBED_IN_OWNER and TOP_LEVEL_IN_WM always get a 
ClientSurfaceEmbedder now.

BUG=
==========

[Fady Samuel, 2017-04-05 23:35:13]

fsamuel@chromium.org changed reviewers:
+ sadrul@chromium.org

[Fady Samuel, 2017-04-05 23:35:14]

PTAL Sadrul.

[Fady Samuel, 2017-04-05 23:35:42]

Description was changed from

==========
Aura-Mus: Implement gutter in the embedder.

This CL implements gutter in the embedder.

In a nutshell, when a Fallback SurfaceInfo is set, the embedder computes 
the right and bottom gutter layers if necessary.

It takes the difference between the window size and the fallback surface 
size, and computes the position and size of the gutters.

The gutter layers are recomputed on window bounds change.

Window types EMBED_IN_OWNER and TOP_LEVEL_IN_WM always get a 
ClientSurfaceEmbedder now.

BUG=
==========

to

==========
Aura-Mus: Implement gutter in the embedder.

This CL implements gutter in the embedder.

In a nutshell, when a Fallback SurfaceInfo is set, the embedder computes 
the right and bottom gutter layers if necessary.

It takes the difference between the window size and the fallback surface 
size, and computes the position and size of the gutters.

The gutter layers are recomputed on window bounds change.

Window types EMBED_IN_OWNER and TOP_LEVEL_IN_WM always get a 
ClientSurfaceEmbedder now.

BUG=672962
==========

[Fady Samuel, 2017-04-05 23:35:52]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[Fady Samuel, 2017-04-05 23:36:49]

Description was changed from

==========
Aura-Mus: Implement gutter in the embedder.

This CL implements gutter in the embedder.

In a nutshell, when a Fallback SurfaceInfo is set, the embedder computes 
the right and bottom gutter layers if necessary.

It takes the difference between the window size and the fallback surface 
size, and computes the position and size of the gutters.

The gutter layers are recomputed on window bounds change.

Window types EMBED_IN_OWNER and TOP_LEVEL_IN_WM always get a 
ClientSurfaceEmbedder now.

BUG=672962
==========

to

==========
Aura-Mus: Implement gutter in the embedder.

This CL implements gutter in the embedder.

In a nutshell, when a Fallback SurfaceInfo is set, the embedder computes 
the right and bottom gutter layers if necessary.

It takes the difference between the window size and the fallback surface 
size, and computes the position and size of the gutters.

The gutter layers are recomputed on window bounds change.

Window types EMBED_IN_OWNER and TOP_LEVEL_IN_WM always get a 
ClientSurfaceEmbedder now.

Note that currently, if surface synchronization is turned on then the frame rate
will always be 15fps because SurfaceLayers may refer (and 
block) on hidden windows that don't produce CompositorFrames. This will
be fixed in a subsequent CL.

BUG=672962
==========

[commit-bot: I haz the power, 2017-04-05 23:36:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2017-04-06 00:02:58]

Description was changed from

==========
Aura-Mus: Implement gutter in the embedder.

This CL implements gutter in the embedder.

In a nutshell, when a Fallback SurfaceInfo is set, the embedder computes 
the right and bottom gutter layers if necessary.

It takes the difference between the window size and the fallback surface 
size, and computes the position and size of the gutters.

The gutter layers are recomputed on window bounds change.

Window types EMBED_IN_OWNER and TOP_LEVEL_IN_WM always get a 
ClientSurfaceEmbedder now.

Note that currently, if surface synchronization is turned on then the frame rate
will always be 15fps because SurfaceLayers may refer (and 
block) on hidden windows that don't produce CompositorFrames. This will
be fixed in a subsequent CL.

BUG=672962
==========

to

==========
Aura-Mus: Implement gutter in the embedder.

This CL implements gutter in the embedder.

In a nutshell, when a Fallback SurfaceInfo is set, the embedder computes 
the right and bottom gutter layers if necessary.

It takes the difference between the window size and the fallback surface 
size, and computes the position and size of the gutters.

The gutter layers are recomputed on window bounds change.

Window types EMBED_IN_OWNER and TOP_LEVEL_IN_WM always get a 
ClientSurfaceEmbedder now.

Note that currently, if surface synchronization is turned on then the 
frame rate will always be 15fps because SurfaceLayers may refer (and 
block) on hidden windows that don't produce CompositorFrames. This will
be fixed in a subsequent CL.

BUG=672962
==========

[commit-bot: I haz the power, 2017-04-06 00:20:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 00:20:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2017-04-06 20:09:02]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 20:10:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 21:21:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 21:21:21]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-04-07 13:07:33]

https://codereview.chromium.org/2797263002/diff/40001/ui/aura/mus/client_surf...
File ui/aura/mus/client_surface_embedder.cc (right):

https://codereview.chromium.org/2797263002/diff/40001/ui/aura/mus/client_surf...
ui/aura/mus/client_surface_embedder.cc:70: ?
surface_layer_->GetFallbackSurfaceInfo()->size_in_pixels()
Add a TODO here for high-dpi

https://codereview.chromium.org/2797263002/diff/40001/ui/aura/mus/client_surf...
ui/aura/mus/client_surface_embedder.cc:74: right_gutter_.reset(new
ui::Layer(ui::LAYER_SOLID_COLOR));
MakeUnique

https://codereview.chromium.org/2797263002/diff/40001/ui/aura/mus/client_surf...
ui/aura/mus/client_surface_embedder.cc:75:
right_gutter_->SetColor(SK_ColorWHITE);
TODO for the color?

https://codereview.chromium.org/2797263002/diff/40001/ui/aura/mus/client_surf...
ui/aura/mus/client_surface_embedder.cc:87: // Only create
Finish the c

https://codereview.chromium.org/2797263002/diff/40001/ui/aura/mus/client_surf...
ui/aura/mus/client_surface_embedder.cc:88: if (!fallback_surface_size.IsEmpty()
&&
Check for empty size before the right gutter and return early, instead of
checking here?

https://codereview.chromium.org/2797263002/diff/40001/ui/aura/mus/client_surf...
File ui/aura/mus/client_surface_embedder.h (left):

https://codereview.chromium.org/2797263002/diff/40001/ui/aura/mus/client_surf...
ui/aura/mus/client_surface_embedder.h:45: std::unique_ptr<ui::Layer>
clip_layer_;
Do we not need the clip layer anymore (e.g. during resize, when the fallback is
actually larger than the desired size)?

https://codereview.chromium.org/2797263002/diff/40001/ui/aura/mus/window_port...
File ui/aura/mus/window_port_mus.cc (right):

https://codereview.chromium.org/2797263002/diff/40001/ui/aura/mus/window_port...
ui/aura/mus/window_port_mus.cc:47: // SetPrimarySurfaceInfo(cc::SurfaceInfo());
Remove

https://codereview.chromium.org/2797263002/diff/40001/ui/aura/mus/window_tree...
File ui/aura/mus/window_tree_client_unittest.cc (right):

https://codereview.chromium.org/2797263002/diff/40001/ui/aura/mus/window_tree...
ui/aura/mus/window_tree_client_unittest.cc:207: // a bounds, a valid FrameSinkId
and is visible.
Visibility is no longer needed, right?

https://codereview.chromium.org/2797263002/diff/40001/ui/aura/mus/window_tree...
ui/aura/mus/window_tree_client_unittest.cc:228: // a valid FrameSinkId.
Update comment

[Fady Samuel, 2017-04-07 15:27:25]

PTAL Sadrul!

https://codereview.chromium.org/2797263002/diff/40001/ui/aura/mus/client_surf...
File ui/aura/mus/client_surface_embedder.cc (right):

https://codereview.chromium.org/2797263002/diff/40001/ui/aura/mus/client_surf...
ui/aura/mus/client_surface_embedder.cc:70: ?
surface_layer_->GetFallbackSurfaceInfo()->size_in_pixels()
On 2017/04/07 13:07:33, sadrul wrote:
> Add a TODO here for high-dpi

Done.

https://codereview.chromium.org/2797263002/diff/40001/ui/aura/mus/client_surf...
ui/aura/mus/client_surface_embedder.cc:74: right_gutter_.reset(new
ui::Layer(ui::LAYER_SOLID_COLOR));
On 2017/04/07 13:07:33, sadrul wrote:
> MakeUnique

Done.

https://codereview.chromium.org/2797263002/diff/40001/ui/aura/mus/client_surf...
ui/aura/mus/client_surface_embedder.cc:75:
right_gutter_->SetColor(SK_ColorWHITE);
On 2017/04/07 13:07:33, sadrul wrote:
> TODO for the color?

Done.

https://codereview.chromium.org/2797263002/diff/40001/ui/aura/mus/client_surf...
ui/aura/mus/client_surface_embedder.cc:87: // Only create
On 2017/04/07 13:07:33, sadrul wrote:
> Finish the c

Done.

https://codereview.chromium.org/2797263002/diff/40001/ui/aura/mus/client_surf...
ui/aura/mus/client_surface_embedder.cc:88: if (!fallback_surface_size.IsEmpty()
&&
On 2017/04/07 13:07:33, sadrul wrote:
> Check for empty size before the right gutter and return early, instead of
> checking here?

Can't I want to make sure that the surface layer's stacking is always above. I
want the last line to execute. I think.

https://codereview.chromium.org/2797263002/diff/40001/ui/aura/mus/client_surf...
File ui/aura/mus/client_surface_embedder.h (left):

https://codereview.chromium.org/2797263002/diff/40001/ui/aura/mus/client_surf...
ui/aura/mus/client_surface_embedder.h:45: std::unique_ptr<ui::Layer>
clip_layer_;
On 2017/04/07 13:07:33, sadrul wrote:
> Do we not need the clip layer anymore (e.g. during resize, when the fallback
is
> actually larger than the desired size)?

We do not need it. SetMasksToBounds(true) on the surface layer is enough.

https://codereview.chromium.org/2797263002/diff/40001/ui/aura/mus/window_port...
File ui/aura/mus/window_port_mus.cc (right):

https://codereview.chromium.org/2797263002/diff/40001/ui/aura/mus/window_port...
ui/aura/mus/window_port_mus.cc:47: // SetPrimarySurfaceInfo(cc::SurfaceInfo());
On 2017/04/07 13:07:33, sadrul wrote:
> Remove

Done.

https://codereview.chromium.org/2797263002/diff/40001/ui/aura/mus/window_tree...
File ui/aura/mus/window_tree_client_unittest.cc (right):

https://codereview.chromium.org/2797263002/diff/40001/ui/aura/mus/window_tree...
ui/aura/mus/window_tree_client_unittest.cc:207: // a bounds, a valid FrameSinkId
and is visible.
On 2017/04/07 13:07:33, sadrul wrote:
> Visibility is no longer needed, right?

Done.

https://codereview.chromium.org/2797263002/diff/40001/ui/aura/mus/window_tree...
ui/aura/mus/window_tree_client_unittest.cc:228: // a valid FrameSinkId.
On 2017/04/07 13:07:33, sadrul wrote:
> Update comment

Done.

[Fady Samuel, 2017-04-07 15:27:30]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 15:27:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 16:23:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 16:23:56]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2017-04-07 16:25:56]

PTAL Sadrul!

[sadrul, 2017-04-07 21:54:41]

lgtm

https://codereview.chromium.org/2797263002/diff/60001/ui/aura/mus/client_surf...
File ui/aura/mus/client_surface_embedder.cc (right):

https://codereview.chromium.org/2797263002/diff/60001/ui/aura/mus/client_surf...
ui/aura/mus/client_surface_embedder.cc:74: if (fallback_surface_size.width() <
window_bounds.width()) {
You should check for fallback_surface_size being empty here too.

[Fady Samuel, 2017-04-07 21:58:48]

CQ'ing thanks.

https://codereview.chromium.org/2797263002/diff/60001/ui/aura/mus/client_surf...
File ui/aura/mus/client_surface_embedder.cc (right):

https://codereview.chromium.org/2797263002/diff/60001/ui/aura/mus/client_surf...
ui/aura/mus/client_surface_embedder.cc:74: if (fallback_surface_size.width() <
window_bounds.width()) {
On 2017/04/07 21:54:41, sadrul wrote:
> You should check for fallback_surface_size being empty here too.

Actually that's deliberate. I want the right gutter to fill the client area if
we don't have a fallback surface yet.

[Fady Samuel, 2017-04-07 21:58:53]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2017-04-07 21:59:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 23:17:10]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491602333660960,
"parent_rev": "c6564f4e73457259075fd14acd488970b156c281", "commit_rev":
"0cbd038c0fb0221a18b27ef3cf52362f5b2d1877"}

[commit-bot: I haz the power, 2017-04-07 23:17:55]

Description was changed from

==========
Aura-Mus: Implement gutter in the embedder.

This CL implements gutter in the embedder.

In a nutshell, when a Fallback SurfaceInfo is set, the embedder computes 
the right and bottom gutter layers if necessary.

It takes the difference between the window size and the fallback surface 
size, and computes the position and size of the gutters.

The gutter layers are recomputed on window bounds change.

Window types EMBED_IN_OWNER and TOP_LEVEL_IN_WM always get a 
ClientSurfaceEmbedder now.

Note that currently, if surface synchronization is turned on then the 
frame rate will always be 15fps because SurfaceLayers may refer (and 
block) on hidden windows that don't produce CompositorFrames. This will
be fixed in a subsequent CL.

BUG=672962
==========

to

==========
Aura-Mus: Implement gutter in the embedder.

This CL implements gutter in the embedder.

In a nutshell, when a Fallback SurfaceInfo is set, the embedder computes 
the right and bottom gutter layers if necessary.

It takes the difference between the window size and the fallback surface 
size, and computes the position and size of the gutters.

The gutter layers are recomputed on window bounds change.

Window types EMBED_IN_OWNER and TOP_LEVEL_IN_WM always get a 
ClientSurfaceEmbedder now.

Note that currently, if surface synchronization is turned on then the 
frame rate will always be 15fps because SurfaceLayers may refer (and 
block) on hidden windows that don't produce CompositorFrames. This will
be fixed in a subsequent CL.

BUG=672962

Review-Url: https://codereview.chromium.org/2797263002
Cr-Commit-Position: refs/heads/master@{#463041}
Committed:
https://chromium.googlesource.com/chromium/src/+/0cbd038c0fb0221a18b27ef3cf52...
==========

[commit-bot: I haz the power, 2017-04-07 23:17:56]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0cbd038c0fb0221a18b27ef3cf52...