Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2797253009: Fix static initializer in ic.cc (Closed)

Created:
3 years, 8 months ago by Lei Zhang
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Fix static initializer in ic.cc This was added in commit 40611, but the std::cout calls are gone so the header is no longer needed. Remove trailing spaces in html files rom the same commit and from other html files in the same directory. Review-Url: https://codereview.chromium.org/2797253009 Cr-Commit-Position: refs/heads/master@{#44535} Committed: https://chromium.googlesource.com/v8/v8/+/df0eaff48dd4eaae6072f3434bca23420fcfc2f1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -12 lines) Patch
M src/ic/ic.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/callstats.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/ic-explorer.html View 4 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
Lei Zhang
I'm not sure how this made it past the static initializer checker in the first ...
3 years, 8 months ago (2017-04-07 21:00:21 UTC) #4
Camillo Bruni
lgtm
3 years, 8 months ago (2017-04-10 09:17:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797253009/1
3 years, 8 months ago (2017-04-10 17:12:33 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/38879)
3 years, 8 months ago (2017-04-10 17:15:24 UTC) #11
Lei Zhang
+jkummerow for OWNERS
3 years, 8 months ago (2017-04-10 17:35:32 UTC) #13
Jakob Kummerow
lgtm
3 years, 8 months ago (2017-04-10 17:36:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797253009/1
3 years, 8 months ago (2017-04-10 17:38:57 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 17:45:43 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/df0eaff48dd4eaae6072f3434bca23420fc...

Powered by Google App Engine
This is Rietveld 408576698