Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 2797253006: Add find_timeouts and caching to tools/gardening (Closed)

Created:
3 years, 8 months ago by Johnni Winther
Modified:
3 years, 8 months ago
Reviewers:
Dmitry Stefantsov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+624 lines, -220 lines) Patch
M tools/gardening/README.md View 1 chunk +11 lines, -0 lines 0 comments Download
M tools/gardening/bin/compare_failures.dart View 1 3 chunks +11 lines, -172 lines 0 comments Download
M tools/gardening/bin/create_shard_groups.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/gardening/bin/current_summary.dart View 1 3 chunks +18 lines, -28 lines 0 comments Download
A tools/gardening/bin/find_timeouts.dart View 1 1 chunk +139 lines, -0 lines 0 comments Download
M tools/gardening/bin/shard2group.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gardening/bin/status_summary.dart View 1 2 chunks +9 lines, -3 lines 0 comments Download
M tools/gardening/lib/src/buildbot_data.dart View 3 chunks +49 lines, -5 lines 0 comments Download
A tools/gardening/lib/src/buildbot_loading.dart View 1 chunk +140 lines, -0 lines 0 comments Download
M tools/gardening/lib/src/buildbot_structures.dart View 3 chunks +146 lines, -0 lines 0 comments Download
A tools/gardening/lib/src/cache.dart View 1 chunk +48 lines, -0 lines 0 comments Download
M tools/gardening/lib/src/logdog.dart View 7 chunks +15 lines, -6 lines 0 comments Download
M tools/gardening/lib/src/util.dart View 1 3 chunks +31 lines, -2 lines 0 comments Download
M tools/gardening/pubspec.yaml View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 8 months ago (2017-04-06 08:29:42 UTC) #2
Dmitry Stefantsov
LGTM with one small question. Nice to see this tool evolving! https://codereview.chromium.org/2797253006/diff/1/tools/gardening/lib/src/util.dart File tools/gardening/lib/src/util.dart (right): ...
3 years, 8 months ago (2017-04-06 09:16:11 UTC) #3
Johnni Winther
https://codereview.chromium.org/2797253006/diff/1/tools/gardening/lib/src/util.dart File tools/gardening/lib/src/util.dart (right): https://codereview.chromium.org/2797253006/diff/1/tools/gardening/lib/src/util.dart#newcode69 tools/gardening/lib/src/util.dart:69: void printOptions() { On 2017/04/06 09:16:10, Dmitry Stefantsov wrote: ...
3 years, 8 months ago (2017-04-06 10:06:07 UTC) #4
Johnni Winther
3 years, 8 months ago (2017-04-06 10:08:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f4050f8739de926f85e720faacfb38f35f890ab6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698