Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: tools/gardening/bin/current_summary.dart

Issue 2797253006: Add find_timeouts and caching to tools/gardening (Closed)
Patch Set: Updated cf. comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gardening/bin/create_shard_groups.dart ('k') | tools/gardening/bin/find_timeouts.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gardening/bin/current_summary.dart
diff --git a/tools/gardening/bin/current_summary.dart b/tools/gardening/bin/current_summary.dart
index 4d9b8c406a12cf37579f426a4792a168bb82aecf..78e813b59677beddb4b3c8645470c806c154ac3f 100644
--- a/tools/gardening/bin/current_summary.dart
+++ b/tools/gardening/bin/current_summary.dart
@@ -11,13 +11,20 @@
import 'dart:math';
import 'dart:io';
+import 'package:args/args.dart';
import 'package:gardening/src/buildbot_data.dart';
+import 'package:gardening/src/buildbot_loading.dart';
import 'package:gardening/src/buildbot_structures.dart';
import 'package:gardening/src/util.dart';
main(List<String> args) async {
- if (args.length == 0) {
- print('Usage: current_summary <test-name1> [<test-name2> ...]');
+ ArgParser argParser = createArgParser();
+ ArgResults argResults = argParser.parse(args);
+ processArgResults(argResults);
+ if (argResults.rest.length == 0) {
+ print('Usage: current_summary [options] <test-name1> [<test-name2> ...]');
+ print('where options are:');
+ print(argParser.usage);
exit(1);
}
int maxStatusWidth = 0;
@@ -31,22 +38,15 @@ main(List<String> args) async {
// use build number `-1`.
for (BuildUri buildUri in group.createUris(-2)) {
print('Reading $buildUri');
- String text = await readUriAsText(client, buildUri.toUri());
- for (String line in text.split('\n')) {
- if (line.startsWith('Done ')) {
- List<String> parts = split(line, ['Done ', ' ', ' ', ': ']);
- String testName = parts[3];
- String configName = parts[1];
- String archName = parts[2];
- String status = parts[4];
- TestStatus testStatus = new TestStatus(
- new TestConfiguration(configName, archName, testName), status);
- for (String arg in args) {
- if (testName.contains(arg) || arg.contains(testName)) {
- resultMap.putIfAbsent(testName, () => {})[buildUri] = testStatus;
- maxStatusWidth = max(maxStatusWidth, status.length);
- maxConfigWidth = max(maxConfigWidth, configName.length);
- }
+ BuildResult buildResult = await readBuildResult(client, buildUri);
+ for (TestStatus testStatus in buildResult.results) {
+ String testName = testStatus.config.testName;
+ for (String arg in argResults.rest) {
+ if (testName.contains(arg) || arg.contains(testName)) {
+ resultMap.putIfAbsent(testName, () => {})[buildUri] = testStatus;
+ maxStatusWidth = max(maxStatusWidth, testStatus.status.length);
+ maxConfigWidth =
+ max(maxConfigWidth, testStatus.config.configName.length);
}
}
}
@@ -63,13 +63,3 @@ main(List<String> args) async {
});
client.close();
}
-
-/// The result of a single test for a single test step.
-class TestStatus {
- final TestConfiguration config;
- final String status;
-
- TestStatus(this.config, this.status);
-
- String toString() => '$config: $status';
-}
« no previous file with comments | « tools/gardening/bin/create_shard_groups.dart ('k') | tools/gardening/bin/find_timeouts.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698