Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h

Issue 2797213002: Fix BaseRenderingContext2D create/put/get-ImageData() for color managed canvas (Closed)
Patch Set: Rebaseline Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h
diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h
index 93b0fc7b5271d6d2b91c8f3240bf29d50a3cb211..0aa6020b541a1c445b82c71851f909b15dc3313e 100644
--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h
+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h
@@ -91,7 +91,7 @@ class MODULES_EXPORT CanvasRenderingContext2D final
~CanvasRenderingContext2D() override;
- void SetCanvasGetContextResult(RenderingContext&) final;
+ void SetCanvasGetContextResult(blink::RenderingContext&) final;
bool isContextLost() const override;
@@ -200,6 +200,18 @@ class MODULES_EXPORT CanvasRenderingContext2D final
void WillDrawImage(CanvasImageSource*) const final;
+ ImageData* createImageData(ImageData*, ExceptionState&) const;
fserb 2017/04/11 03:21:44 do we need those on CanvasRenderingContext2D at al
zakerinasab 2017/04/11 19:53:00 All moved to BaseRenderingContext2D.
+ ImageData* createImageData(int, int, ExceptionState&) const;
+ ImageData* createImageData(unsigned,
+ unsigned,
+ ImageDataColorSettings&,
+ ExceptionState&) const;
+ ImageData* createImageData(ImageDataArray&,
+ unsigned,
+ unsigned,
+ ImageDataColorSettings&,
+ ExceptionState&) const;
+
protected:
virtual void NeedsFinalizeFrame() {
CanvasRenderingContext::NeedsFinalizeFrame();
@@ -237,6 +249,11 @@ class MODULES_EXPORT CanvasRenderingContext2D final
CanvasRenderingContext::ContextType GetContextType() const override {
return CanvasRenderingContext::kContext2d;
}
+
+ CanvasColorSpace ColorSpace() const override;
+ String ColorSpaceAsString() const override;
+ CanvasPixelFormat PixelFormat() const override;
+
bool Is2d() const override { return true; }
bool IsComposited() const override;
bool IsAccelerated() const override;

Powered by Google App Engine
This is Rietveld 408576698