Fix BaseRenderingContext2D create/put/get-ImageData() for color managed canvas

third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
index 3f30acc316777eb081bb255dcb476dd34f56c882..168bc9c2f92e567ff61ba86362126c7467f9e2d6 100644
--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
@@ -279,6 +279,50 @@ void CanvasRenderingContext2D::WillDrawImage(CanvasImageSource* source) const {
   canvas()->WillDrawImageTo2DContext(source);
 }
 
+ImageData* CanvasRenderingContext2D::createImageData(
+    ImageData* image_data,
+    ExceptionState& exception_state) const {
+  return BaseRenderingContext2D::createImageData(image_data, exception_state);
+}
+
+ImageData* CanvasRenderingContext2D::createImageData(
+    int sw,
+    int sh,
+    ExceptionState& exception_state) const {
+  return BaseRenderingContext2D::createImageData(sw, sh, exception_state);
+}
+
+ImageData* CanvasRenderingContext2D::createImageData(
+    unsigned width,
+    unsigned height,
+    ImageDataColorSettings& color_settings,
+    ExceptionState& exception_state) const {
+  return ImageData::createImageData(width, height, color_settings,

[fserb, 2017/04/11 03:21:44]

I'm a bit confused why don't you have to use BaseRenderingContext2D here?
It feels to me that all those functions should disappear and just have a
BaseRenderingContext2D implementation of all of them.

[zakerinasab, 2017/04/11 19:52:59]

Done.

+                                    exception_state);
+}
+
+ImageData* CanvasRenderingContext2D::createImageData(
+    ImageDataArray& data_array,
+    unsigned width,
+    unsigned height,
+    ImageDataColorSettings& color_settings,
+    ExceptionState& exception_state) const {
+  return ImageData::createImageData(data_array, width, height, color_settings,
+                                    exception_state);
+}
+
+CanvasColorSpace CanvasRenderingContext2D::ColorSpace() const {
+  return CanvasRenderingContext::ColorSpace();

[fserb, 2017/04/11 03:21:44]

fyi: Yeah, I'm fixing this on the next refactor. :)

[zakerinasab, 2017/04/11 19:53:00]

:)

+}
+
+String CanvasRenderingContext2D::ColorSpaceAsString() const {
+  return CanvasRenderingContext::ColorSpaceAsString();
+}
+
+CanvasPixelFormat CanvasRenderingContext2D::PixelFormat() const {
+  return CanvasRenderingContext::PixelFormat();
+}
+
 ColorBehavior CanvasRenderingContext2D::DrawImageColorBehavior() const {
   return CanvasRenderingContext::ColorBehaviorForMediaDrawnToCanvas();
 }