Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Issue 2797163002: cryptohome: Make CryptohomeClient::Unmount non-blocking (Closed)

Created:
3 years, 8 months ago by hashimoto
Modified:
3 years, 8 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, oshima+watch_chromium.org, hashimoto+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cryptohome: Make CryptohomeClient::Unmount non-blocking eCryptfs->ext4 crypto migrator will use Unmount. Before adding a new user, stop blocking the UI thread for this D-Bus method call. BUG=702526 TEST=unit_tests --gtest_filter="CryptohomeAuthenticatorTest.*" Review-Url: https://codereview.chromium.org/2797163002 Cr-Commit-Position: refs/heads/master@{#462311} Committed: https://chromium.googlesource.com/chromium/src/+/e792e0e91d5b20121b9eb634b43af7eeb04b612f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -20 lines) Patch
M chromeos/dbus/cryptohome_client.h View 1 chunk +1 line, -2 lines 0 comments Download
M chromeos/dbus/cryptohome_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/dbus/fake_cryptohome_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/fake_cryptohome_client.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chromeos/dbus/mock_cryptohome_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/login/auth/cryptohome_authenticator.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chromeos/login/auth/cryptohome_authenticator.cc View 2 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
hashimoto
xiyuan@, could you review this CL?
3 years, 8 months ago (2017-04-05 10:15:23 UTC) #4
xiyuan
lgtm
3 years, 8 months ago (2017-04-05 16:38:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797163002/1
3 years, 8 months ago (2017-04-06 01:18:08 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 01:35:57 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e792e0e91d5b20121b9eb634b43a...

Powered by Google App Engine
This is Rietveld 408576698