Add FaviconHandler test for UpdateFaviconMappingsAndFetch()

Add FaviconHandler test for UpdateFaviconMappingsAndFetch()

Addresses a minor TODO introduced during the review of
https://codereview.chromium.org/2703603002

The idea is to have dedicated tests to verify
UpdateFaviconMappingsAndFetch(), and avoid repeated verifications in
other tests.

BUG=694312
Review-Url: https://codereview.chromium.org/2797143002
Cr-Commit-Position: refs/heads/master@{#462399}
Committed: https://chromium.googlesource.com/chromium/src/+/441188cddd4de0849944aac1dd1779b391bedb69

[mastiz, 2017-04-05 08:13:45]

mastiz@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[pkotwicz, 2017-04-05 15:16:57]

LGTM with nit

https://codereview.chromium.org/2797143002/diff/1/components/favicon/core/fav...
File components/favicon/core/favicon_handler_unittest.cc (left):

https://codereview.chromium.org/2797143002/diff/1/components/favicon/core/fav...
components/favicon/core/favicon_handler_unittest.cc:426: // - There is no data
in the database for neither the page URL nor the icon URL.
Nit: "There is no data" -> "There is data"

[mastiz, 2017-04-06 08:13:53]

https://codereview.chromium.org/2797143002/diff/1/components/favicon/core/fav...
File components/favicon/core/favicon_handler_unittest.cc (left):

https://codereview.chromium.org/2797143002/diff/1/components/favicon/core/fav...
components/favicon/core/favicon_handler_unittest.cc:426: // - There is no data
in the database for neither the page URL nor the icon URL.
On 2017/04/05 15:16:57, pkotwicz wrote:
> Nit: "There is no data" -> "There is data"

Done.

[mastiz, 2017-04-06 08:13:58]

The CQ bit was checked by mastiz@chromium.org

[mastiz, 2017-04-06 08:13:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkotwicz@chromium.org
Link to the patchset: https://codereview.chromium.org/2797143002/#ps20001
(title: "Fixed comment.")

[commit-bot: I haz the power, 2017-04-06 08:14:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 09:01:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491466438833450,
"parent_rev": "51feb2d65333500aa71a395346b189a4fa65ee4c", "commit_rev":
"441188cddd4de0849944aac1dd1779b391bedb69"}

[commit-bot: I haz the power, 2017-04-06 09:02:55]

Description was changed from

==========
Add FaviconHandler test for UpdateFaviconMappingsAndFetch()

Addresses a minor TODO introduced during the review of
https://codereview.chromium.org/2703603002

The idea is to have dedicated tests to verify
UpdateFaviconMappingsAndFetch(), and avoid repeated verifications in
other tests.

BUG=694312
==========

to

==========
Add FaviconHandler test for UpdateFaviconMappingsAndFetch()

Addresses a minor TODO introduced during the review of
https://codereview.chromium.org/2703603002

The idea is to have dedicated tests to verify
UpdateFaviconMappingsAndFetch(), and avoid repeated verifications in
other tests.

BUG=694312

Review-Url: https://codereview.chromium.org/2797143002
Cr-Commit-Position: refs/heads/master@{#462399}
Committed:
https://chromium.googlesource.com/chromium/src/+/441188cddd4de0849944aac1dd17...
==========

[commit-bot: I haz the power, 2017-04-06 09:02:56]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/441188cddd4de0849944aac1dd17...