Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2797133009: Better detection of MP4 files (Closed)

Created:
3 years, 8 months ago by jrummell
Modified:
3 years, 8 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Better detection of MP4 files Relax the restrictions on the list of top-level boxes so that MP4 files are more reliably detected. BUG=709166 TEST=updated test passes Review-Url: https://codereview.chromium.org/2797133009 Cr-Commit-Position: refs/heads/master@{#462759} Committed: https://chromium.googlesource.com/chromium/src/+/169982cfc8c9619b413f133606cc832845e5d069

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -19 lines) Patch
M media/base/container_names.cc View 2 chunks +25 lines, -19 lines 0 comments Download
M media/base/container_names_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
jrummell
PTAL.
3 years, 8 months ago (2017-04-06 22:41:21 UTC) #2
DaleCurtis
Nice! lgtm
3 years, 8 months ago (2017-04-06 22:53:03 UTC) #3
DaleCurtis
We should merge back to m58 if this reduces counts on canary.
3 years, 8 months ago (2017-04-06 22:53:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797133009/1
3 years, 8 months ago (2017-04-07 02:39:05 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 05:09:12 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/169982cfc8c9619b413f133606cc...

Powered by Google App Engine
This is Rietveld 408576698