Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2797133007: [MD settings] add custom spelling words to top of list (Closed)

Created:
3 years, 8 months ago by dschuyler
Modified:
3 years, 8 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] add custom spelling words to top of list This CL changes how new custom spelling words are added in the settings. Rather than adding to the bottom of the list and trying to scroll to the new word, the new word is added to the top of the list. This also keeps the input field visible on long lists of words (it's frustrating to need to repeatedly scroll to the top to add the next word). BUG=708425 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2797133007 Cr-Commit-Position: refs/heads/master@{#462654} Committed: https://chromium.googlesource.com/chromium/src/+/5d4d9ba0b0e6c15675c151733e4a77902a9fae02

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M chrome/browser/resources/settings/languages_page/edit_dictionary_page.js View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
dschuyler
3 years, 8 months ago (2017-04-06 19:27:22 UTC) #5
stevenjb
lgtm
3 years, 8 months ago (2017-04-06 20:29:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797133007/1
3 years, 8 months ago (2017-04-06 21:24:38 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 22:33:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5d4d9ba0b0e6c15675c151733e4a...

Powered by Google App Engine
This is Rietveld 408576698