Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2797133002: Replace base::get with std::get (Closed)

Created:
3 years, 8 months ago by tzik
Modified:
3 years, 8 months ago
Reviewers:
danakj
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace base::get with std::get base::get is no longer needed after the linux sysroot update. The new sysroot has libstdc++-4.8, that has rvalue reference support of std::tuple. Review-Url: https://codereview.chromium.org/2797133002 Cr-Commit-Position: refs/heads/master@{#462229} Committed: https://chromium.googlesource.com/chromium/src/+/f7c47573b7686c59723f3b7da6d69f1ec494f23b

Patch Set 1 #

Patch Set 2 : +styleguide #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -46 lines) Patch
M base/bind_internal.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/tuple.h View 4 chunks +3 lines, -17 lines 0 comments Download
M base/tuple_unittest.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M styleguide/c++/c++11.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
tzik
PTAL
3 years, 8 months ago (2017-04-05 06:07:35 UTC) #6
danakj
LGTM
3 years, 8 months ago (2017-04-05 15:02:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797133002/20001
3 years, 8 months ago (2017-04-05 20:15:25 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 21:45:56 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f7c47573b7686c59723f3b7da6d6...

Powered by Google App Engine
This is Rietveld 408576698