Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 2797093002: Add net public_deps in content/public/common:common_sources, and the followon public_deps in conten… (Closed)

Created:
3 years, 8 months ago by mattm
Modified:
3 years, 8 months ago
Reviewers:
piman
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add net public_deps in content/public/common:common_sources, and the followon public_deps in content/public/browser:browser_sources. BUG=none Review-Url: https://codereview.chromium.org/2797093002 Cr-Commit-Position: refs/heads/master@{#462244} Committed: https://chromium.googlesource.com/chromium/src/+/ac7d5f39fa14c9b0f980a498c5ced6a79b77d113

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/public/browser/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M content/public/common/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
mattm
content/public/common/referrer.h includes net headers, therefore //net should be in content/public/common:common_sources public_deps. content/public/browser/navigation_controller.h includes content/public/common/referrer.h, therefore ...
3 years, 8 months ago (2017-04-05 03:20:25 UTC) #4
piman
lgtm
3 years, 8 months ago (2017-04-05 19:15:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797093002/1
3 years, 8 months ago (2017-04-05 22:14:27 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 22:24:47 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ac7d5f39fa14c9b0f980a498c5ce...

Powered by Google App Engine
This is Rietveld 408576698