Chromium Code Reviews
DescriptionTest cases for querySelector fast paths.
Historically we only had perf tests for the various fast paths
but that makes it hard to know what's really happening and if a
change in the SelectorQuery code changed behavior (ex.
Searching too many elements but still finding the right answer).
This patch introduces a system that tracks counters inside
SelectorQuery (only enabled with dchecks) that let us
write tests to verify the fast paths.
I then wrote a bunch of tests and added comments about edge
cases that are handled poorly by the fast paths today.
BUG=703900
Review-Url: https://codereview.chromium.org/2797083002
Cr-Commit-Position: refs/heads/master@{#462526}
Committed: https://chromium.googlesource.com/chromium/src/+/c00d9dec2a75f7ab0ca2220066c93f7749b797f2
Patch Set 1 #Patch Set 2 : Make the tests work. #Patch Set 3 : Working tests. #
Messages
Total messages: 15 (11 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||