Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2797073002: Move WebTextCheckClient reference from WebViewImpl to WebLocalFrameImpl (Closed)
Patch Set: Tue Apr 4 20:53:35 PDT 2017 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebViewImpl.h
diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h
index d885987f9305d3b9ffff86ac25b5873f1dc6ad57..d0788d9bae5c0bb8dd74f806c862d58baa291b3f 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.h
+++ b/third_party/WebKit/Source/web/WebViewImpl.h
@@ -174,7 +174,6 @@ class WEB_EXPORT WebViewImpl final
void setCredentialManagerClient(WebCredentialManagerClient*) override;
void setPrerendererClient(WebPrerendererClient*) override;
void setSpellCheckClient(WebSpellCheckClient*) override;
- void setTextCheckClient(WebTextCheckClient*) override;
WebSettings* settings() override;
WebString pageEncoding() const override;
bool tabsToLinks() const override;
@@ -314,8 +313,6 @@ class WEB_EXPORT WebViewImpl final
WebSpellCheckClient* spellCheckClient() { return m_spellCheckClient; }
- WebTextCheckClient* textCheckClient() { return m_textCheckClient; }
-
// Returns the page object associated with this view. This may be null when
// the page is shutting down, but will be valid at all other times.
Page* page() const { return m_page.get(); }
@@ -615,9 +612,6 @@ class WEB_EXPORT WebViewImpl final
WebViewClient* m_client; // Can be 0 (e.g. unittests, shared workers, etc.)
WebSpellCheckClient* m_spellCheckClient;
- // TODO(xiaochengh): Move this pointer to WebLocalFrameImpl.
- WebTextCheckClient* m_textCheckClient;
-
Persistent<ChromeClientImpl> m_chromeClientImpl;
ContextMenuClientImpl m_contextMenuClientImpl;
EditorClientImpl m_editorClientImpl;

Powered by Google App Engine
This is Rietveld 408576698