Move WebTextCheckClient reference from WebViewImpl to WebLocalFrameImpl

chrome/renderer/chrome_content_renderer_client.cc

Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index 77fd3cadaba22631c2b2c6b4747a090a3ef09c0f..cca8dc16905ffda451bc0c184c18f743abe0989c 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -565,6 +565,14 @@ void ChromeContentRendererClient::RenderFrameCreated(
       render_frame->IsMainFrame()) {
     new SearchBox(render_frame);
   }
+
+#if BUILDFLAG(ENABLE_SPELLCHECK)
+  // TODO(xiaochengh): Use a different SpellCheckProvider for each RenderFrame.
+  if (SpellCheckProvider* provider =
+          SpellCheckProvider::Get(render_frame->GetRenderView())) {

[Lei Zhang, 2017/04/05 20:20:44]

Looking at RenderFrameImpl::GetRenderView() and how it's used internally, it
should never returns a nullptr. So if all RenderView creation reaches
ChromeContentRendererClient::RenderViewCreated(), where you create the
SpellCheckProvider, then this should never return a nullptr either.

[Xiaocheng, 2017/04/05 20:26:15]

I found that for the first RenderFrame in a RenderView, RenderFrameCreated() is
called earlier than RenderViewCreated().

So when we reach here, it's possible that the SpellCheckProvider for the
RenderView hasn't been created yet.

[Lei Zhang, 2017/04/05 20:35:35]

Oh, we are in RenderFrameCreated(). I don't know enough about spell check to say
whether it's ok for the first (main?) RenderFrame to not have a client set. If
it must be set, maybe add a check to see if the client is set for the main frame
in RenderViewCreated() below and set it there instead after creating the
SpellCheckProvider?

It feels hacky, but I imagine the problem will go away once SpellCheckProvider
is a RenderFrameObserver.

[Xiaocheng, 2017/04/05 22:32:07]

Yes, each RenderFrame must have its client set. Do you mean:
- For a subframe, set its client in RenderFrameCreate()
- For the main frame, set its client in RenderViewCreated right after creating
the SpellCheckProvider?
Yeah it's hacky for now. Once SpellCheckProvider becomes RFO, we only need to
set the client in SpellCheckProvider::ctor and all hacks will be gone.

[Lei Zhang, 2017/04/05 22:38:19]

Based on your prior statements, my mental picture says it'll have to be done
this way.
It sounds like we are in agreement?

[Xiaocheng, 2017/04/05 22:43:34]

Yep :)

+    render_frame->GetWebFrame()->setTextCheckClient(provider);
+  }
+#endif
 }
 
 void ChromeContentRendererClient::RenderViewCreated(