Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2797063004: Rename pageinfo_strings.grdp to page_info_strings.grdp (Closed)

Created:
3 years, 8 months ago by lgarron
Modified:
3 years, 8 months ago
CC:
chromium-reviews, estark
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename pageinfo_strings.grdp to page_info_strings.grdp BUG=708368 Review-Url: https://codereview.chromium.org/2797063004 Cr-Commit-Position: refs/heads/master@{#462162} Committed: https://chromium.googlesource.com/chromium/src/+/f2e2a6510e391b9573fdba04f77cc1786660a8f5

Patch Set 1 #

Patch Set 2 : Rename pageinfo_strings.grdp to page_info_strings.grdp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -116 lines) Patch
M components/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M components/components_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
A + components/page_info_strings.grdp View 0 chunks +-1 lines, --1 lines 0 comments Download
D components/pageinfo_strings.grdp View 1 chunk +0 lines, -114 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
lgarron
jochen@, could you review?
3 years, 8 months ago (2017-04-05 01:07:08 UTC) #2
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-04-05 08:33:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797063004/20001
3 years, 8 months ago (2017-04-05 17:30:31 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 18:53:49 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f2e2a6510e391b9573fdba04f77c...

Powered by Google App Engine
This is Rietveld 408576698