recipe_modules/step/example.py - Issue 2797023002: Always identify test names that lead to failures - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(774)

My Issues | Starred Open | Closed | All

Unified Diff: recipe_modules/step/example.py

Issue 2797023002: Always identify test names that lead to failures (Closed)

Patch Set: review Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« recipe_engine/test_result.proto ('K') | « recipe_engine/test_result_pb2.py ('k') | unittests/test_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: recipe_modules/step/example.py

diff --git a/recipe_modules/step/example.py b/recipe_modules/step/example.py

index 3f7c69d81bf445f7612828a685644d229808dca7..c18eb98ceada2f462ace4715505c9319ffabf13e 100644

--- a/recipe_modules/step/example.py

+++ b/recipe_modules/step/example.py

@@ -32,6 +32,7 @@ def RunSteps(

# Timeout causes the recipe engine to raise an exception if your step takes

# longer to run than you allow. Units are seconds.

if timeout == 1:

+ raise Exception('fuu')

iannucci 2017/04/04 20:24:51 did you mean to leave this in? should this be adde

Paweł Hajdan Jr. 2017/04/04 20:32:03 Ouch, indeed left by mistake. Also detected by pre

api.step('timeout', ['sleep', '20'], timeout=1)

elif timeout == 2:

try:

« recipe_engine/test_result.proto ('K') | « recipe_engine/test_result_pb2.py ('k') | unittests/test_test.py » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698