Always identify test names that lead to failures

recipe_engine/test_result.proto

Index: recipe_engine/test_result.proto
diff --git a/recipe_engine/test_result.proto b/recipe_engine/test_result.proto
index 25ac5f72261630904b298cfca5029cb4fd6cdd89..a37127558a19c3c67693c4d02199cb563cbed3d6 100644
--- a/recipe_engine/test_result.proto
+++ b/recipe_engine/test_result.proto
@@ -51,11 +51,16 @@ message TestResult {
     int64 lineno = 6;
   }
 
+  message InternalFailure {
+  }
+
   message TestFailure {
     oneof failures {
       DiffFailure diff_failure = 1;
 
       CheckFailure check_failure = 2;
+
+      InternalFailure internal_failure = 3;

[iannucci, 2017/04/04 20:24:51]

I suspect 'internal_failure' isn't quite right; most of the time this just means
that the recipe code needs modification. Maybe 'incompatibility_failure'?

followup: I would also add some comments to this proto to document what the
different failure types mean, exactly.

[Paweł Hajdan Jr., 2017/04/04 20:32:03]

Added comment to the proto.

As indicated by the comment, incompatibility in user recipe code is not the only
case which can trigger this.

     }
   }