Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2796923002:
[qcms] Only accept valid input ranges when reading VCGT formula (Closed)
|
Created:
3 years, 8 months ago by Noel Gordon Modified:
3 years, 8 months ago CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[qcms] Only accept valid input ranges when reading VCGT formula
According to the documentation for CMVideoCardGammaFormula, when
building a LUT from a VCGT formula, the formula parameter values
- gamma: must be greater than 0.0
- min: must be greater than 0.0 and less than 1.0
- max: must be greater than 0.0 and less than 1.0
BUG=708145
Review-Url: https://codereview.chromium.org/2796923002
Cr-Commit-Position: refs/heads/master@{#461904}
Committed: https://chromium.googlesource.com/chromium/src/+/f98ec4aaf012f3d7720d88f9977b0e49946a4843
Patch Set 1 #
Total comments: 4
Patch Set 2 : Fix QCMS tab vs. spaces per usual. #
Messages
Total messages: 25 (17 generated)
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Only accept valid input ranges when reading VCGT tag LUT According to the documentation for CMVideoCardGammaFormula - gamma must be greater than 0.0 - min must be greater than 0.0 and less than 1.0 - max must be greater than 0.0 and less than 1.0 BUG=708145 ========== to ========== [qcms] Only accept valid input ranges when reading VCGT tag LUT According to the documentation for CMVideoCardGammaFormula - gamma must be greater than 0.0 - min must be greater than 0.0 and less than 1.0 - max must be greater than 0.0 and less than 1.0 BUG=708145 ==========
noel@chromium.org changed reviewers: + hubbe@chromium.org
PTAL.
robert.bradford@intel.com changed reviewers: + robert.bradford@intel.com
In the commit message can you clarify that this is for the formula mode rather than the LUT mode. https://codereview.chromium.org/2796923002/diff/1/third_party/qcms/src/iccread.c File third_party/qcms/src/iccread.c (right): https://codereview.chromium.org/2796923002/diff/1/third_party/qcms/src/iccrea... third_party/qcms/src/iccread.c:487: goto invalid_vcgt_tag; lgtm. But something has gone wrong with the identation here. Would be good to fix before CQ. https://codereview.chromium.org/2796923002/diff/1/third_party/qcms/src/iccrea... third_party/qcms/src/iccread.c:749: curve->parameter[i] = s15Fixed16Number_to_float(read_s15Fixed16Number(src, offset + 12 + i*4)); I don't think you need this hunk.
Description was changed from ========== [qcms] Only accept valid input ranges when reading VCGT tag LUT According to the documentation for CMVideoCardGammaFormula - gamma must be greater than 0.0 - min must be greater than 0.0 and less than 1.0 - max must be greater than 0.0 and less than 1.0 BUG=708145 ========== to ========== [qcms] Only accept valid input ranges when reading VCGT tag LUT According to the documentation for CMVideoCardGammaFormula, when building a LUT from a VCGT formula, the formula parameter values: - gamma: must be greater than 0.0 - min: must be greater than 0.0 and less than 1.0 - max: must be greater than 0.0 and less than 1.0 BUG=708145 ==========
Description was changed from ========== [qcms] Only accept valid input ranges when reading VCGT tag LUT According to the documentation for CMVideoCardGammaFormula, when building a LUT from a VCGT formula, the formula parameter values: - gamma: must be greater than 0.0 - min: must be greater than 0.0 and less than 1.0 - max: must be greater than 0.0 and less than 1.0 BUG=708145 ========== to ========== [qcms] Only accept valid input ranges when reading VCGT tag LUT According to the documentation for CMVideoCardGammaFormula, when building a LUT from a VCGT formula, the formula parameter values - gamma: must be greater than 0.0 - min: must be greater than 0.0 and less than 1.0 - max: must be greater than 0.0 and less than 1.0 BUG=708145 ==========
On 2017/04/04 13:54:24, robert.bradford wrote: > In the commit message can you clarify that this is for the formula mode rather > than the LUT mode. Done.
https://codereview.chromium.org/2796923002/diff/1/third_party/qcms/src/iccread.c File third_party/qcms/src/iccread.c (right): https://codereview.chromium.org/2796923002/diff/1/third_party/qcms/src/iccrea... third_party/qcms/src/iccread.c:487: goto invalid_vcgt_tag; On 2017/04/04 13:54:24, robert.bradford wrote: > lgtm. But something has gone wrong with the identation here. Would be good to > fix before CQ. Ah yes, my editor is in chromium mode, not qcms mode. Let me fix. https://codereview.chromium.org/2796923002/diff/1/third_party/qcms/src/iccrea... third_party/qcms/src/iccread.c:749: curve->parameter[i] = s15Fixed16Number_to_float(read_s15Fixed16Number(src, offset + 12 + i*4)); On 2017/04/04 13:54:24, robert.bradford wrote: > I don't think you need this hunk. Agree, my editor again, will fix.
Description was changed from ========== [qcms] Only accept valid input ranges when reading VCGT tag LUT According to the documentation for CMVideoCardGammaFormula, when building a LUT from a VCGT formula, the formula parameter values - gamma: must be greater than 0.0 - min: must be greater than 0.0 and less than 1.0 - max: must be greater than 0.0 and less than 1.0 BUG=708145 ========== to ========== [qcms] Only accept valid input ranges when reading VCGT formula According to the documentation for CMVideoCardGammaFormula, when building a LUT from a VCGT formula, the formula parameter values - gamma: must be greater than 0.0 - min: must be greater than 0.0 and less than 1.0 - max: must be greater than 0.0 and less than 1.0 BUG=708145 ==========
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/04/04 14:11:34, noel gordon wrote: > Ah yes, my editor is in chromium mode, not qcms mode. Let me fix. Thanks for spotting, Robert. Fixed: now with tabs, diff looks "right".
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by noel@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from robert.bradford@intel.com Link to the patchset: https://codereview.chromium.org/2796923002/#ps40001 (title: "Fix QCMS tab vs. spaces per usual.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491349644743370,
"parent_rev": "36920277941e915314f558ada0a27236c633f751", "commit_rev":
"f98ec4aaf012f3d7720d88f9977b0e49946a4843"}
Message was sent while issue was closed.
Description was changed from ========== [qcms] Only accept valid input ranges when reading VCGT formula According to the documentation for CMVideoCardGammaFormula, when building a LUT from a VCGT formula, the formula parameter values - gamma: must be greater than 0.0 - min: must be greater than 0.0 and less than 1.0 - max: must be greater than 0.0 and less than 1.0 BUG=708145 ========== to ========== [qcms] Only accept valid input ranges when reading VCGT formula According to the documentation for CMVideoCardGammaFormula, when building a LUT from a VCGT formula, the formula parameter values - gamma: must be greater than 0.0 - min: must be greater than 0.0 and less than 1.0 - max: must be greater than 0.0 and less than 1.0 BUG=708145 Review-Url: https://codereview.chromium.org/2796923002 Cr-Commit-Position: refs/heads/master@{#461904} Committed: https://chromium.googlesource.com/chromium/src/+/f98ec4aaf012f3d7720d88f9977b... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/f98ec4aaf012f3d7720d88f9977b... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
