Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2796903003: Implement the HTTPToDirectFallback Integration Test with ChromeDriver (Closed)

Created:
3 years, 8 months ago by jiewu
Modified:
3 years, 8 months ago
Reviewers:
RyanSturm, bustamante
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement the HTTPToDirectFallback Integration Test with ChromeDriver BUG=680565 Review-Url: https://codereview.chromium.org/2796903003 Cr-Commit-Position: refs/heads/master@{#462209} Committed: https://chromium.googlesource.com/chromium/src/+/56ab65b0a75d340fdb41bd5530d8c27bd2ad283e

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address code review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M tools/chrome_proxy/webdriver/fallback.py View 1 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
bustamante
lgtm, thanks!
3 years, 8 months ago (2017-04-05 17:28:04 UTC) #2
RyanSturm
lgtm https://codereview.chromium.org/2796903003/diff/1/tools/chrome_proxy/webdriver/fallback.py File tools/chrome_proxy/webdriver/fallback.py (right): https://codereview.chromium.org/2796903003/diff/1/tools/chrome_proxy/webdriver/fallback.py#newcode79 tools/chrome_proxy/webdriver/fallback.py:79: 'http://nonexistent.googlezip.net') maybe https:// instead of http://
3 years, 8 months ago (2017-04-05 18:47:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2796903003/20001
3 years, 8 months ago (2017-04-05 20:33:41 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 20:51:30 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/56ab65b0a75d340fdb41bd5530d8...

Powered by Google App Engine
This is Rietveld 408576698