Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2796893002: [qcms] Fix overflow when reading parametric gamma curves (Closed)

Created:
3 years, 8 months ago by Noel Gordon
Modified:
3 years, 8 months ago
Reviewers:
hubbe
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[qcms] Fix overflow when reading parametric gamma curves The ICC spec does not impose input restrictions to compute a parametric curve LUT. The largest value computed can reach about pow(65536,32768). To prevent explicit handling of a large double, use powf(), and prevent precision loss by executing right-to-left. BUG=708143 Review-Url: https://codereview.chromium.org/2796893002 Cr-Commit-Position: refs/heads/master@{#461947} Committed: https://chromium.googlesource.com/chromium/src/+/0eb3418b597de14bff675fde0e575fbc947ff962

Patch Set 1 #

Patch Set 2 : Sync up, fix QCMS tab vs. spaces per usual. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/qcms/README.chromium View 1 2 chunks +3 lines, -1 line 0 comments Download
M third_party/qcms/src/transform_util.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (11 generated)
Noel Gordon
PTAL.
3 years, 8 months ago (2017-04-04 13:03:56 UTC) #4
hubbe
lgtm
3 years, 8 months ago (2017-04-04 17:32:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2796893002/20001
3 years, 8 months ago (2017-04-05 01:37:37 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 02:38:19 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0eb3418b597de14bff675fde0e57...

Powered by Google App Engine
This is Rietveld 408576698