Sending autofill types for username fields in sign-in forms for improving username detection.

components/autofill/core/browser/form_structure.cc

Index: components/autofill/core/browser/form_structure.cc
diff --git a/components/autofill/core/browser/form_structure.cc b/components/autofill/core/browser/form_structure.cc
index fb32f01eb21ab5215ee82447679a7949546208c1..0896bb4f426772e8c846870d22bb5f84da1741c0 100644
--- a/components/autofill/core/browser/form_structure.cc
+++ b/components/autofill/core/browser/form_structure.cc
@@ -309,7 +309,8 @@ FormStructure::FormStructure(const FormData& form)
       has_password_field_(false),
       is_form_tag_(form.is_form_tag),
       is_formless_checkout_(form.is_formless_checkout),
-      all_fields_are_passwords_(true) {
+      all_fields_are_passwords_(true),
+      is_signin_upload_(false) {
   // Copy the form fields.
   std::map<base::string16, size_t> unique_names;
   for (const FormFieldData& field : form.fields) {
@@ -613,7 +614,7 @@ bool FormStructure::ShouldBeParsed() const {
   if (active_field_count() < kRequiredFieldsForPredictionRoutines &&
       (!all_fields_are_passwords() ||
        active_field_count() < kRequiredFieldsForFormsWithOnlyPasswordFields) &&
-      !has_author_specified_types_) {
+      !is_signin_upload_ && !has_author_specified_types_) {

[Roger McFarlane (Chromium), 2017/04/04 19:09:42]

hmm... digging into this boolean logic...

The change here is to allow signing upload forms to be parsed, even though they
don't fit the other # of fields minimums, right?

I read this as "Do not parse the form if...

  there are too few fields in general
    AND (some fields are not passwords
         OR (there are too few fields for passwords only
             AND its not a signin upload
             AND there are no author specified types
            )
        )"

Plz confirm that this is what you intended?

[dvadym, 2017/04/05 13:28:28]

Yes, it's correct, it allows sign-in uploads to be parsed, and only uploads, not
queries for such forms. 

     return false;
   }