Sending autofill types for username fields in sign-in forms for improving username detection.

components/autofill/core/browser/autofill_manager.cc

Index: components/autofill/core/browser/autofill_manager.cc
diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc
index d599bce07603f84b97bd881bbe88c249078ea123..ecd58bd3ecf1e40d1f51ef37fd7926534bf7675b 100644
--- a/components/autofill/core/browser/autofill_manager.cc
+++ b/components/autofill/core/browser/autofill_manager.cc
@@ -2007,6 +2007,11 @@ void AutofillManager::DeterminePossibleFieldTypesForUpload(
   // profile or credit card, identify any stored types that match the value.
   for (size_t i = 0; i < submitted_form->field_count(); ++i) {
     AutofillField* field = submitted_form->field(i);
+    if (!field->possible_types().empty()) {
+      // If this is an upload for password form submission, Password Manager
+      // could already set types for some fields.

[Roger McFarlane (Chromium), 2017/04/04 19:09:42]

The goal of this function is to include all of the data matches; I'm not sure I
agree with the early continue. Why do we want to exclude the other potential
field types?

[dvadym, 2017/04/05 13:28:28]

Good point. I thought, when I was writing this code, that we are interested only
in password types. But with your comment to password_form_manager, I've realized
that sometimes we could save some other type of information, that's obviously
incorrect, and adding all votes we can figure out when we fail. 
I've updated code, for adding new types in possible_types

+      continue;
+    }
     ServerFieldTypeSet matching_types;
 
     base::string16 value;