Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2796823002: Convert onchange-js.html test for testharness.js. (Closed)

Created:
3 years, 8 months ago by tkent
Modified:
3 years, 8 months ago
Reviewers:
kochi
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert onchange-js.html test for testharness.js. This is a preparation to fix crbug.com/706370. This CL has no behavior changes. BUG=706370 Review-Url: https://codereview.chromium.org/2796823002 Cr-Commit-Position: refs/heads/master@{#461661} Committed: https://chromium.googlesource.com/chromium/src/+/b0c201c3dd37577f185f97bd397c4a8012ce17bc

Patch Set 1 : . #

Total comments: 2

Patch Set 2 : Remove </html> #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -124 lines) Patch
D third_party/WebKit/LayoutTests/fast/events/onchange-js.html View 1 chunk +0 lines, -82 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/onchange-js-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/forms/textfield-change-event.html View 1 1 chunk +79 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tkent
kochi@, would you review this please? This is a trivial test conversion.
3 years, 8 months ago (2017-04-04 06:26:06 UTC) #5
kochi
LGTM https://codereview.chromium.org/2796823002/diff/20001/third_party/WebKit/LayoutTests/fast/forms/textfield-change-event.html File third_party/WebKit/LayoutTests/fast/forms/textfield-change-event.html (right): https://codereview.chromium.org/2796823002/diff/20001/third_party/WebKit/LayoutTests/fast/forms/textfield-change-event.html#newcode80 third_party/WebKit/LayoutTests/fast/forms/textfield-change-event.html:80: </html> nit: You don't have opening <html> tag.
3 years, 8 months ago (2017-04-04 06:39:00 UTC) #6
tkent
https://codereview.chromium.org/2796823002/diff/20001/third_party/WebKit/LayoutTests/fast/forms/textfield-change-event.html File third_party/WebKit/LayoutTests/fast/forms/textfield-change-event.html (right): https://codereview.chromium.org/2796823002/diff/20001/third_party/WebKit/LayoutTests/fast/forms/textfield-change-event.html#newcode80 third_party/WebKit/LayoutTests/fast/forms/textfield-change-event.html:80: </html> On 2017/04/04 at 06:38:59, kochi wrote: > nit: ...
3 years, 8 months ago (2017-04-04 07:00:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2796823002/40001
3 years, 8 months ago (2017-04-04 07:01:03 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 08:37:00 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b0c201c3dd37577f185f97bd397c...

Powered by Google App Engine
This is Rietveld 408576698