[ios] Adds a LocationBarController interface.

[ios] Adds a LocationBarController interface.

Renames the existing LocationBarViewIOS class to LocationBarControllerImpl.
Moves files into ios/shared.

BUG=708151
Review-Url: https://codereview.chromium.org/2796793003
Cr-Commit-Position: refs/heads/master@{#461729}
Committed: https://chromium.googlesource.com/chromium/src/+/cd324eb7d820806adc5a2830c613d0976ebb73ad

[rohitrao (ping after 24h), 2017-04-04 13:35:16]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 13:35:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rohitrao (ping after 24h), 2017-04-04 13:38:17]

rohitrao@chromium.org changed reviewers:
+ sdefresne@chromium.org

[rohitrao (ping after 24h), 2017-04-04 13:38:18]

https://codereview.chromium.org/2796793003/diff/1/ios/chrome/browser/ui/brows...
File ios/chrome/browser/ui/browser_view_controller.mm (right):

https://codereview.chromium.org/2796793003/diff/1/ios/chrome/browser/ui/brows...
ios/chrome/browser/ui/browser_view_controller.mm:38: #include
"base/strings/utf_string_conversions.h"
There are a few IWYU changes in this CL, because I removed an include from
WebToolbarController.

https://codereview.chromium.org/2796793003/diff/1/ios/chrome/browser/ui/omnib...
File ios/chrome/browser/ui/omnibox/BUILD.gn (right):

https://codereview.chromium.org/2796793003/diff/1/ios/chrome/browser/ui/omnib...
ios/chrome/browser/ui/omnibox/BUILD.gn:37: "location_bar_controller_impl.h",
This file will eventually move into ios/shared, but it's going to take 100 other
files with it.

[commit-bot: I haz the power, 2017-04-04 13:42:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 13:42:21]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[rohitrao (ping after 24h), 2017-04-04 13:45:46]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 13:46:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-04-04 13:58:17]

lgtm (my comments are spread on the two patchset because using a web site is
hard)

https://codereview.chromium.org/2796793003/diff/1/ios/chrome/browser/ui/brows...
File ios/chrome/browser/ui/browser_view_controller.mm (right):

https://codereview.chromium.org/2796793003/diff/1/ios/chrome/browser/ui/brows...
ios/chrome/browser/ui/browser_view_controller.mm:38: #include
"base/strings/utf_string_conversions.h"
On 2017/04/04 13:38:18, rohitrao wrote:
> There are a few IWYU changes in this CL, because I removed an include from
> WebToolbarController.

Acknowledged.

https://codereview.chromium.org/2796793003/diff/1/ios/chrome/browser/ui/omnib...
File ios/chrome/browser/ui/omnibox/BUILD.gn (right):

https://codereview.chromium.org/2796793003/diff/1/ios/chrome/browser/ui/omnib...
ios/chrome/browser/ui/omnibox/BUILD.gn:37: "location_bar_controller_impl.h",
On 2017/04/04 13:38:18, rohitrao wrote:
> This file will eventually move into ios/shared, but it's going to take 100
other
> files with it.

Acknowledged.

https://codereview.chromium.org/2796793003/diff/1/ios/chrome/browser/ui/omnib...
File ios/chrome/browser/ui/omnibox/location_bar_controller_impl.h (left):

https://codereview.chromium.org/2796793003/diff/1/ios/chrome/browser/ui/omnib...
ios/chrome/browser/ui/omnibox/location_bar_controller_impl.h:34: // Delegate for
LocationBarViewIOS objects.  Used to provide the location bar a
I like that you move the delegate to a separate file!

https://codereview.chromium.org/2796793003/diff/1/ios/chrome/browser/ui/toolb...
File ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm (right):

https://codereview.chromium.org/2796793003/diff/1/ios/chrome/browser/ui/toolb...
ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm:601:
_locationBar.reset(new LocationBarControllerImpl(_omniBox, _browserState,
nit: use base::MakeUnique if possible

  _locationBar = base::MakeUnique<...>(...);

https://codereview.chromium.org/2796793003/diff/1/ios/chrome/browser/ui/toolb...
File ios/chrome/browser/ui/toolbar/web_toolbar_controller_private.h (right):

https://codereview.chromium.org/2796793003/diff/1/ios/chrome/browser/ui/toolb...
ios/chrome/browser/ui/toolbar/web_toolbar_controller_private.h:8: #import
"ios/chrome/browser/ui/toolbar/web_toolbar_controller.h"
Should go below <> import/includes.

https://codereview.chromium.org/2796793003/diff/1/ios/shared/chrome/browser/u...
File ios/shared/chrome/browser/ui/omnibox/BUILD.gn (right):

https://codereview.chromium.org/2796793003/diff/1/ios/shared/chrome/browser/u...
ios/shared/chrome/browser/ui/omnibox/BUILD.gn:1: # Copyright 2016 The Chromium
Authors. All rights reserved.
2017

https://codereview.chromium.org/2796793003/diff/20001/ios/chrome/browser/ui/o...
File ios/chrome/browser/ui/omnibox/location_bar_controller_impl.mm (right):

https://codereview.chromium.org/2796793003/diff/20001/ios/chrome/browser/ui/o...
ios/chrome/browser/ui/omnibox/location_bar_controller_impl.mm:121: :
edit_view_(new OmniboxViewIOS(field,
nit: use base::MakeUnique<> if possible

[rohitrao (ping after 24h), 2017-04-04 14:32:30]

https://codereview.chromium.org/2796793003/diff/1/ios/chrome/browser/ui/toolb...
File ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm (right):

https://codereview.chromium.org/2796793003/diff/1/ios/chrome/browser/ui/toolb...
ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm:601:
_locationBar.reset(new LocationBarControllerImpl(_omniBox, _browserState,
On 2017/04/04 13:58:16, sdefresne wrote:
> nit: use base::MakeUnique if possible
> 
>   _locationBar = base::MakeUnique<...>(...);

Done.

https://codereview.chromium.org/2796793003/diff/1/ios/chrome/browser/ui/toolb...
File ios/chrome/browser/ui/toolbar/web_toolbar_controller_private.h (right):

https://codereview.chromium.org/2796793003/diff/1/ios/chrome/browser/ui/toolb...
ios/chrome/browser/ui/toolbar/web_toolbar_controller_private.h:8: #import
"ios/chrome/browser/ui/toolbar/web_toolbar_controller.h"
On 2017/04/04 13:58:16, sdefresne wrote:
> Should go below <> import/includes.

Done.

https://codereview.chromium.org/2796793003/diff/1/ios/shared/chrome/browser/u...
File ios/shared/chrome/browser/ui/omnibox/BUILD.gn (right):

https://codereview.chromium.org/2796793003/diff/1/ios/shared/chrome/browser/u...
ios/shared/chrome/browser/ui/omnibox/BUILD.gn:1: # Copyright 2016 The Chromium
Authors. All rights reserved.
On 2017/04/04 13:58:17, sdefresne wrote:
> 2017

Done.

https://codereview.chromium.org/2796793003/diff/20001/ios/chrome/browser/ui/o...
File ios/chrome/browser/ui/omnibox/location_bar_controller_impl.mm (right):

https://codereview.chromium.org/2796793003/diff/20001/ios/chrome/browser/ui/o...
ios/chrome/browser/ui/omnibox/location_bar_controller_impl.mm:121: :
edit_view_(new OmniboxViewIOS(field,
On 2017/04/04 13:58:17, sdefresne wrote:
> nit: use base::MakeUnique<> if possible

Done.

[rohitrao (ping after 24h), 2017-04-04 14:32:42]

The CQ bit was checked by rohitrao@chromium.org

[rohitrao (ping after 24h), 2017-04-04 14:32:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2796793003/#ps40001
(title: "Review.")

[commit-bot: I haz the power, 2017-04-04 14:33:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 15:36:46]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491316362318450,
"parent_rev": "1de903938832ed377f635aa4475639b8ca40ceb6", "commit_rev":
"cd324eb7d820806adc5a2830c613d0976ebb73ad"}

[commit-bot: I haz the power, 2017-04-04 15:37:37]

Description was changed from

==========
[ios] Adds a LocationBarController interface.

Renames the existing LocationBarViewIOS class to LocationBarControllerImpl.
Moves files into ios/shared.

BUG=708151
==========

to

==========
[ios] Adds a LocationBarController interface.

Renames the existing LocationBarViewIOS class to LocationBarControllerImpl.
Moves files into ios/shared.

BUG=708151

Review-Url: https://codereview.chromium.org/2796793003
Cr-Commit-Position: refs/heads/master@{#461729}
Committed:
https://chromium.googlesource.com/chromium/src/+/cd324eb7d820806adc5a2830c613...
==========

[commit-bot: I haz the power, 2017-04-04 15:37:38]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cd324eb7d820806adc5a2830c613...