Issue 2796793002: CUPS: Fix the Print Preview UI regression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2796793002: CUPS: Fix the Print Preview UI regression. (Closed)

Created:
3 years, 8 months ago by caseq

Modified:
3 years, 8 months ago

Reviewers:
dpapad

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3061

Project:
chromium

Visibility:
Public.

CUPS: Fix the Print Preview UI regression. It's a regression caused by https://codereview.chromium.org/2760753002/. I forgot the function invocation "this". BUG=707634 TBR=dpapad@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2796603002 Cr-Commit-Position: refs/heads/master@{#461385} (cherry picked from commit 3b53ec368dfffde2441b14afaae376f36bd906f2) Review-Url: https://codereview.chromium.org/2796793002 . Cr-Commit-Position: refs/branch-heads/3061@{#6} Cr-Branched-From: 9e03960f75b3019372157db5c4fe5264dfc36616-refs/heads/master@{#461353} Committed: https://chromium.googlesource.com/chromium/src/+/6980a49d3a55296ebeda6d724673686abe6bafd6

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/resources/print_preview/search/destination_list_item.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

caseq

3 years, 8 months ago (2017-04-04 02:04:45 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6980a49d3a55296ebeda6d724673686abe6bafd6.