Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 2796723002: Add CommentToken.parent and implement CommentToken.remove(). (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
ahe, Paul Berry, danrubel
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -41 lines) Patch
M pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/token.dart View 2 chunks +10 lines, -16 lines 0 comments Download
M pkg/front_end/test/scanner_fasta_test.dart View 3 chunks +85 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-04-03 21:07:24 UTC) #1
danrubel
LGTM
3 years, 8 months ago (2017-04-03 21:26:48 UTC) #2
scheglov
3 years, 8 months ago (2017-04-03 21:27:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ef166a64810283f1be302cbe27c2115a5f9b1492 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698