Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: pkg/front_end/lib/src/fasta/scanner/token.dart

Issue 2796723002: Add CommentToken.parent and implement CommentToken.remove(). (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/scanner/token.dart
diff --git a/pkg/front_end/lib/src/fasta/scanner/token.dart b/pkg/front_end/lib/src/fasta/scanner/token.dart
index 83a98013e5b66f58f4d088e9393235800f18e022..4be106753f8b614957d70cda0d0db311352c22ad 100644
--- a/pkg/front_end/lib/src/fasta/scanner/token.dart
+++ b/pkg/front_end/lib/src/fasta/scanner/token.dart
@@ -463,6 +463,9 @@ class StringToken extends Token implements analyzer.StringToken {
}
class CommentToken extends StringToken implements analyzer.CommentToken {
+ @override
+ analyzer.TokenWithComment parent;
+
/**
* Creates a lazy comment token. If [canonicalize] is true, the string
* is canonicalized before the token is created.
@@ -495,23 +498,14 @@ class CommentToken extends StringToken implements analyzer.CommentToken {
new CommentToken._(info, valueOrLazySubstring, charOffset);
@override
- analyzer.TokenWithComment get parent {
- Token token = next;
- while (token is CommentToken) {
- token = token.next;
- }
- return token;
- }
-
- @override
- void set parent(analyzer.TokenWithComment ignored) {
- throw 'unsupported operation';
- }
-
- @override
void remove() {
- // TODO: implement remove
- throw 'not implemented yet';
+ if (previous != null) {
+ previous.setNextWithoutSettingPrevious(next);
+ next?.previous = previous;
+ } else {
+ assert(parent.precedingComments == this);
+ parent.precedingComments = next as CommentToken;
+ }
}
}
« no previous file with comments | « pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart ('k') | pkg/front_end/test/scanner_fasta_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698