Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 2796683002: Remove ExtractImageRep usage in CanvasImageSource. (Closed)

Created:
3 years, 8 months ago by danakj
Modified:
3 years, 8 months ago
Reviewers:
sadrul
CC:
chromium-reviews, rsesek+watch_chromium.org, enne (OOO), Peter Kasting
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ExtractImageRep usage in CanvasImageSource. The CanvasImageSource already makes a gfx::Canvas with a bitmap backing so it can use GetBitmap to get access to the bitmap and insert that into a ImageSkiaRep. This also avoids copying the pixels. R=sadrul@chromium.org BUG=671433 Review-Url: https://codereview.chromium.org/2796683002 Cr-Commit-Position: refs/heads/master@{#461714} Committed: https://chromium.googlesource.com/chromium/src/+/06dd2aba57ad74e18fd72861062b3712443045a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/gfx/image/canvas_image_source.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (11 generated)
danakj
3 years, 8 months ago (2017-04-03 22:04:18 UTC) #7
sadrul
lgtm
3 years, 8 months ago (2017-04-04 04:10:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2796683002/1
3 years, 8 months ago (2017-04-04 14:46:53 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 14:53:00 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/06dd2aba57ad74e18fd72861062b...

Powered by Google App Engine
This is Rietveld 408576698