Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(889)

Issue 2796673003: Deflake suborigin-invalid-options.html (Closed)

Created:
3 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 8 months ago
Reviewers:
Mike West
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Deflake suborigin-invalid-options.html Just force the five tests to run in order. BUG=705125, 671475 R=mkwst@chromium.org Review-Url: https://codereview.chromium.org/2796673003 Cr-Commit-Position: refs/heads/master@{#461719} Committed: https://chromium.googlesource.com/chromium/src/+/9d48fc928e4b278649c3155f11749f100892ed70

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -18 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-invalid-options.html View 1 chunk +28 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
jochen (gone - plz use gerrit)
3 years, 8 months ago (2017-04-04 13:58:57 UTC) #1
Mike West
I don't understand why the test requires running in order, but this approach seems totally ...
3 years, 8 months ago (2017-04-04 14:16:24 UTC) #4
Mike West
(LGTM)
3 years, 8 months ago (2017-04-04 14:16:33 UTC) #5
jochen (gone - plz use gerrit)
On 2017/04/04 at 14:16:33, mkwst wrote: > (LGTM) because depending on which iframe loads first, ...
3 years, 8 months ago (2017-04-04 14:24:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2796673003/1
3 years, 8 months ago (2017-04-04 14:24:51 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 15:13:13 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9d48fc928e4b278649c3155f1174...

Powered by Google App Engine
This is Rietveld 408576698