Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6075)

Unified Diff: chrome/browser/ui/search/search_ipc_router.h

Issue 2796643002: NTP: Record TileType metrics also on desktop (Closed)
Patch Set: review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/search_ipc_router.h
diff --git a/chrome/browser/ui/search/search_ipc_router.h b/chrome/browser/ui/search/search_ipc_router.h
index fdd09bed012718faf0fb7b52b9e1ea68afe01490..541e27741d6073efe84a7d3f4a43794c08173374 100644
--- a/chrome/browser/ui/search/search_ipc_router.h
+++ b/chrome/browser/ui/search/search_ipc_router.h
@@ -15,6 +15,7 @@
#include "chrome/common/search/instant_types.h"
#include "chrome/common/search/ntp_logging_events.h"
#include "components/ntp_tiles/tile_source.h"
+#include "components/ntp_tiles/tile_visual_type.h"
#include "components/omnibox/common/omnibox_focus_state.h"
#include "content/public/browser/web_contents_binding_set.h"
#include "content/public/browser/web_contents_observer.h"
@@ -62,12 +63,14 @@ class SearchIPCRouter : public content::WebContentsObserver,
// Called to log an impression from a given provider on the New Tab Page.
virtual void OnLogMostVisitedImpression(
int position,
- ntp_tiles::TileSource tile_source) = 0;
+ ntp_tiles::TileSource tile_source,
+ ntp_tiles::TileVisualType tile_type) = 0;
// Called to log a navigation from a given provider on the New Tab Page.
virtual void OnLogMostVisitedNavigation(
int position,
- ntp_tiles::TileSource tile_source) = 0;
+ ntp_tiles::TileSource tile_source,
+ ntp_tiles::TileVisualType tile_type) = 0;
// Called when the page wants to paste the |text| (or the clipboard contents
// if the |text| is empty) into the omnibox.
@@ -183,10 +186,12 @@ class SearchIPCRouter : public content::WebContentsObserver,
base::TimeDelta time) override;
void LogMostVisitedImpression(int page_seq_no,
int position,
- ntp_tiles::TileSource tile_source) override;
+ ntp_tiles::TileSource tile_source,
+ ntp_tiles::TileVisualType tile_type) override;
void LogMostVisitedNavigation(int page_seq_no,
int position,
- ntp_tiles::TileSource tile_source) override;
+ ntp_tiles::TileSource tile_source,
+ ntp_tiles::TileVisualType tile_type) override;
void PasteAndOpenDropdown(int page_seq_no,
const base::string16& text) override;
void ChromeIdentityCheck(int page_seq_no,

Powered by Google App Engine
This is Rietveld 408576698