Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3414)

Unified Diff: chrome/browser/ui/search/search_ipc_router.cc

Issue 2796643002: NTP: Record TileType metrics also on desktop (Closed)
Patch Set: review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/search_ipc_router.cc
diff --git a/chrome/browser/ui/search/search_ipc_router.cc b/chrome/browser/ui/search/search_ipc_router.cc
index 91449358d27905d38effe8a227b1996e5c7225f0..613021b849fec73a2d705362f1686d843e349cfa 100644
--- a/chrome/browser/ui/search/search_ipc_router.cc
+++ b/chrome/browser/ui/search/search_ipc_router.cc
@@ -251,7 +251,8 @@ void SearchIPCRouter::LogEvent(int page_seq_no,
void SearchIPCRouter::LogMostVisitedImpression(
int page_seq_no,
int position,
- ntp_tiles::TileSource tile_source) {
+ ntp_tiles::TileSource tile_source,
+ ntp_tiles::TileVisualType tile_type) {
if (page_seq_no != commit_counter_)
return;
@@ -260,13 +261,14 @@ void SearchIPCRouter::LogMostVisitedImpression(
if (!policy_->ShouldProcessLogEvent())
return;
- delegate_->OnLogMostVisitedImpression(position, tile_source);
+ delegate_->OnLogMostVisitedImpression(position, tile_source, tile_type);
}
void SearchIPCRouter::LogMostVisitedNavigation(
int page_seq_no,
int position,
- ntp_tiles::TileSource tile_source) {
+ ntp_tiles::TileSource tile_source,
+ ntp_tiles::TileVisualType tile_type) {
if (page_seq_no != commit_counter_)
return;
@@ -275,7 +277,7 @@ void SearchIPCRouter::LogMostVisitedNavigation(
if (!policy_->ShouldProcessLogEvent())
return;
- delegate_->OnLogMostVisitedNavigation(position, tile_source);
+ delegate_->OnLogMostVisitedNavigation(position, tile_source, tile_type);
}
void SearchIPCRouter::PasteAndOpenDropdown(int page_seq_no,

Powered by Google App Engine
This is Rietveld 408576698