Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2796643002: NTP: Record TileType metrics also on desktop (Closed)
Patch Set: Tests! Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 1b6c3aa6d226e4a2a8ac4adea60c715d1822ad47..27d7df796af4edb64c019dc07bcdbc85bf84ec3a 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -42392,19 +42392,19 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</histogram>
<histogram name="NewTabPage.TileType" enum="NTPTileVisualType">
- <owner>newt@chromium.org</owner>
+ <owner>mastiz@chromium.org</owner>
<summary>
The visual type of each most visited tile displayed on the new tab page,
e.g. actual thumbnail or placeholder thumbnail. This is recorded for each
- most visited item when the NTP is opened. Only measured on Android.
+ most visited item when the NTP is opened.
</summary>
</histogram>
<histogram name="NewTabPage.TileTypeClicked" enum="NTPTileVisualType">
- <owner>newt@chromium.org</owner>
+ <owner>mastiz@chromium.org</owner>
<summary>
The visual type of the most visited item that the user clicked on, e.g.
- actual thumbnail or placeholder thumbnail. Only measured on Android.
+ actual thumbnail or placeholder thumbnail.
</summary>
</histogram>
@@ -104458,6 +104458,12 @@ from previous Chrome versions.
<int value="6" label="DeprecatedThumbnailDefault">
Deprecated: The item displays a default graphic in place of a thumbnail.
</int>
+ <int value="7" label="Thumbnail">
+ FIXME he item displays a thumbnail of the page.
sfiera 2017/04/06 08:53:28 FIXIT!
Marc Treib 2017/04/06 09:16:44 Not sure what happened here... sorry, fixed.
+ </int>
+ <int value="8" label="ThumbnailFailed">
+ FIXME The item displays a default gray box in place of a thumbnail.
+ </int>
</enum>
<enum name="NTSTATUS" type="int">
« components/ntp_tiles/metrics_unittest.cc ('K') | « components/ntp_tiles/tile_visual_type.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698