Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: components/ntp_tiles/tile_visual_type.h

Issue 2796643002: NTP: Record TileType metrics also on desktop (Closed)
Patch Set: Tests! Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_tiles/tile_visual_type.h
diff --git a/components/ntp_tiles/tile_visual_type.h b/components/ntp_tiles/tile_visual_type.h
index e1bfea102ee1eb6b68cf8c18889f0f4ffef157c9..f68d393a172d99b8e8e860b7cef1fff0da7be141 100644
--- a/components/ntp_tiles/tile_visual_type.h
+++ b/components/ntp_tiles/tile_visual_type.h
@@ -23,16 +23,17 @@ enum TileVisualType {
ICON_COLOR = 2,
// The item displays a default gray box in place of an icon.
ICON_DEFAULT = 3,
- // The number of different tile types that get recorded. Entries below this
- // are not recorded in UMA.
- NUM_RECORDED_TILE_TYPES,
-
// Deleted: THUMBNAIL_LOCAL = 4
// Deleted: THUMBNAIL_SERVER = 5
// Deleted: THUMBNAIL_DEFAULT = 6
-
// The item displays a thumbnail of the page. Used on desktop.
- THUMBNAIL,
+ THUMBNAIL = 7,
+ // The item wants to display a thumbnail of the page, but it failed to load.
+ // Used on desktop.
+ THUMBNAIL_FAILED = 8,
+ // The maximum tile type value that gets recorded in UMA.
+ MAX_RECORDED_TILE_TYPE = THUMBNAIL_FAILED,
+
// The tile type has not been determined yet. Used on iOS, until we can detect
// when all tiles have loaded.
UNKNOWN_TILE_TYPE,

Powered by Google App Engine
This is Rietveld 408576698