Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/MonochromeApplication.java

Issue 2796453003: android: Limit bindToCaller check to webview (Closed)
Patch Set: fix test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/MonochromeApplication.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/MonochromeApplication.java b/chrome/android/java/src/org/chromium/chrome/browser/MonochromeApplication.java
index 177abe7302db752876e87d7389def3d979778957..22901387632436897db07bb651fd40e9006de8a1 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/MonochromeApplication.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/MonochromeApplication.java
@@ -24,7 +24,8 @@ public class MonochromeApplication extends ChromeApplication {
LibraryLoader.setNativeLibraryPreloader(new MonochromeLibraryPreloader());
// ChildProcessCreationParams is only needed for browser process, though it is
// created and set in all processes.
- ChildProcessCreationParams.registerDefault(new ChildProcessCreationParams(
- getPackageName(), true /* isExternalService */, LibraryProcessType.PROCESS_CHILD));
+ final boolean bindToCaller = false;
nyquist 2017/04/04 18:30:33 Nit: Why are all these final? We usually don't do
boliu 2017/04/04 20:00:07 umm, I guess I'm carrying over from c++. these are
boliu 2017/04/04 21:21:55 removed final in chrome
+ ChildProcessCreationParams.registerDefault(new ChildProcessCreationParams(getPackageName(),
+ true /* isExternalService */, LibraryProcessType.PROCESS_CHILD, bindToCaller));
}
-}
+}

Powered by Google App Engine
This is Rietveld 408576698