chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java - Issue 2796453003: android: Limit bindToCaller check to webview

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

Issue 2796453003: android: Limit bindToCaller check to webview (Closed)

Patch Set: fix test Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/MonochromeApplication.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/MonochromeApplication.java ('k') | content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

index ad8637d86b75f22ad68556ebf62dd4f0a9ab40d5..bc9053aecd057654ad893f880351bc50e1ba5096 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

@@ -165,9 +165,10 @@ public class WebApkActivity extends WebappActivity {

// TODO(hanxi): crbug.com/664530. WebAPKs shouldn't use a global ChildProcessCreationParams.

ChildProcessCreationParams params = mDefaultParams;

if (isForWebApk) {

- boolean isExternalService = false;

+ final boolean isExternalService = false;

+ final boolean bindToCaller = false;

params = new ChildProcessCreationParams(getWebappInfo().webApkPackageName(),

- isExternalService, LibraryProcessType.PROCESS_CHILD);

+ isExternalService, LibraryProcessType.PROCESS_CHILD, bindToCaller);

}

ChildProcessCreationParams.registerDefault(params);

}