Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2796443002: Fix L low-end testing spec on chromium.android.fyi. (Closed)

Created:
3 years, 8 months ago by bpastene
Modified:
3 years, 8 months ago
Reviewers:
jbudorick
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix L low-end testing spec on chromium.android.fyi. notryin' because I'm impatient TBR=jbudorick@chromium.org NOTRY=true BUG=670879 Review-Url: https://codereview.chromium.org/2796443002 Cr-Commit-Position: refs/heads/master@{#461257} Committed: https://chromium.googlesource.com/chromium/src/+/9d766b01914f09b20ef999b3aa6a676c38e65792

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M testing/buildbot/chromium.android.fyi.json View 30 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
bpastene
3 years, 8 months ago (2017-03-31 22:35:30 UTC) #2
bpastene
3 years, 8 months ago (2017-03-31 22:35:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2796443002/1
3 years, 8 months ago (2017-03-31 22:36:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/9d766b01914f09b20ef999b3aa6a676c38e65792
3 years, 8 months ago (2017-03-31 22:43:34 UTC) #9
jbudorick
NOTRYing because you're impatient is not a good habit to get in to... lgtm
3 years, 8 months ago (2017-04-01 01:04:28 UTC) #10
bpastene
On 2017/04/01 01:04:28, jbudorick wrote: > NOTRYing because you're impatient is not a good habit ...
3 years, 8 months ago (2017-04-01 01:13:48 UTC) #11
jbudorick
On 2017/04/01 01:13:48, bpastene wrote: > On 2017/04/01 01:04:28, jbudorick wrote: > > NOTRYing because ...
3 years, 8 months ago (2017-04-01 01:17:43 UTC) #12
jbudorick
3 years, 8 months ago (2017-04-01 01:18:11 UTC) #13
Message was sent while issue was closed.
On 2017/04/01 01:17:43, jbudorick wrote:
> On 2017/04/01 01:13:48, bpastene wrote:
> > On 2017/04/01 01:04:28, jbudorick wrote:
> > > NOTRYing because you're impatient is not a good habit to get in to...
> > > 
> > > lgtm
> > 
> > I don't see the harm here
> 
> It's a bad habit to get into. This immediate CL would not have been affected
by
> the trybots, but please do not get used to doing it. NOTRY is not for CLs that
> you don't think will break anything or for CLs that you don't think will be
> tested by the CQ; it's an escape hatch that should seldom be used outside of
> reverts.

*especially* in combination with TBR.

Powered by Google App Engine
This is Rietveld 408576698